Add init_circuit_data.

[ilyalesokhin-starkware]

This change is 

[orizi]

Reviewed 14 of 15 files at r1, 1 of 2 files at r2.
Reviewable status: 14 of 16 files reviewed, 8 unresolved discussions (waiting on @ilyalesokhin-starkware)

---

corelib/src/circuit.cairo line 15 at r1 (raw file):

extern type CircuitInputAccumulator<C>;

impl CircuitInputAccumulatorDrop<C> of Drop<CircuitInputAccumulator<C>>;

Suggestion:

pub type u96 = core::internal::BoundedInt<0, 79228162514264337593543950335>;
pub extern type RangeCheck96;


/// Defines an input for a circuit.
#[phantom]
pub extern type CircuitInput<const N: usize>;


/// Initializes the input data for running an instance of the circuit.
extern fn init_circuit_data<C>() -> CircuitInputAccumulator<C> implicits(RangeCheck96) nopanic;

/// Type for accumulating inputs into the circuit instance's data.
extern type CircuitInputAccumulator<C>;

impl CircuitInputAccumulatorDrop<C> of Drop<CircuitInputAccumulator<C>>;

---

crates/cairo-lang-sierra/src/extensions/mod.rs line 64 at r1 (raw file):

/// Extracts the generic args of `ty`, additionally validates it is of generic type `T`.
fn extract_type_generic_args<T: NamedType>(

is this useful in other places already?

---

crates/cairo-lang-sierra/src/extensions/modules/circuit.rs line 32 at r1 (raw file):

}

fn is_circuit_component(

doc and maybe use extract_type_generic_args

---

crates/cairo-lang-sierra/src/extensions/modules/circuit.rs line 65 at r1 (raw file):

pub struct ConcreteCircuitInput {
    pub info: TypeInfo,

doc members.

---

crates/cairo-lang-sierra/src/extensions/modules/circuit.rs line 97 at r1 (raw file):

}

/// Add mod gate type.

fix doc.

---

crates/cairo-lang-sierra/src/extensions/modules/circuit.rs line 145 at r1 (raw file):

}

fn parse_circuit(

doc

---

crates/cairo-lang-sierra/src/extensions/modules/circuit.rs line 170 at r1 (raw file):

}

/// Libfunc for ignoring a plain old data object.

fix doc

---

crates/cairo-lang-sierra-to-casm/src/invocations/circuit.rs line 19 at r1 (raw file):

/// Handles a Sierra statement for appending an element to an array.
fn build_array_append(

rename and fix doc.

[orizi]

Reviewed 1 of 2 files at r2, 2 of 3 files at r3, all commit messages.
Reviewable status: 16 of 17 files reviewed, 7 unresolved discussions (waiting on @ilyalesokhin-starkware)

[ilyalesokhin-starkware]

Reviewable status: 16 of 17 files reviewed, 7 unresolved discussions (waiting on @orizi)

---

corelib/src/circuit.cairo line 15 at r1 (raw file):

extern type CircuitInputAccumulator<C>;

impl CircuitInputAccumulatorDrop<C> of Drop<CircuitInputAccumulator<C>>;

Done.

---

crates/cairo-lang-sierra/src/extensions/mod.rs line 64 at r1 (raw file):

Previously, orizi wrote…

is this useful in other places already?

yes, I meant to move it from 'crates/cairo-lang-sierra/src/extensions/modules/const_type.rs.'

---

crates/cairo-lang-sierra/src/extensions/modules/circuit.rs line 32 at r1 (raw file):

Previously, orizi wrote…

doc and maybe use extract_type_generic_args

Done.

---

crates/cairo-lang-sierra/src/extensions/modules/circuit.rs line 65 at r1 (raw file):

Previously, orizi wrote…

doc members.

Done.

---

crates/cairo-lang-sierra/src/extensions/modules/circuit.rs line 97 at r1 (raw file):

Previously, orizi wrote…

fix doc.

removed as the type is documented in circuits.cairo

---

crates/cairo-lang-sierra/src/extensions/modules/circuit.rs line 145 at r1 (raw file):

Previously, orizi wrote…

doc

Done.

---

crates/cairo-lang-sierra/src/extensions/modules/circuit.rs line 170 at r1 (raw file):

Previously, orizi wrote…

fix doc

removed as the libfunc is documented in circuits.cairo

[ilyalesokhin-starkware]

Reviewable status: 15 of 17 files reviewed, 7 unresolved discussions (waiting on @orizi)

---

crates/cairo-lang-sierra-to-casm/src/invocations/circuit.rs line 19 at r1 (raw file):

Previously, orizi wrote…

rename and fix doc.

Done.

[orizi]

Reviewed 1 of 3 files at r3, 1 of 1 files at r4, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @ilyalesokhin-starkware)

---

crates/cairo-lang-sierra/src/extensions/modules/circuit.rs line 65 at r1 (raw file):

Previously, ilyalesokhin-starkware wrote…

Done.

With ///

---

crates/cairo-lang-sierra/src/extensions/modules/circuit.rs line 97 at r1 (raw file):

Previously, ilyalesokhin-starkware wrote…

removed as the type is documented in circuits.cairo

We usually doc in both, as these appear to different sort of users.

---

crates/cairo-lang-sierra/src/extensions/modules/circuit.rs line 170 at r1 (raw file):

Previously, ilyalesokhin-starkware wrote…

removed as the libfunc is documented in circuits.cairo

Same

[ilyalesokhin-starkware]

crates/cairo-lang-sierra/src/extensions/modules/circuit.rs line 97 at r1 (raw file):

Previously, orizi wrote…

We usually doc in both, as these appear to different sort of users.

just copy the same comment?

[orizi]

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @ilyalesokhin-starkware)

---

crates/cairo-lang-sierra/src/extensions/modules/circuit.rs line 97 at r1 (raw file):

Previously, ilyalesokhin-starkware wrote…

just copy the same comment?

good enough for me

[ilyalesokhin-starkware]

Reviewable status: 15 of 17 files reviewed, 3 unresolved discussions (waiting on @orizi)

---

crates/cairo-lang-sierra/src/extensions/modules/circuit.rs line 65 at r1 (raw file):

Previously, orizi wrote…

With ///

Done.

---

crates/cairo-lang-sierra/src/extensions/modules/circuit.rs line 97 at r1 (raw file):

Previously, orizi wrote…

good enough for me

Done.

---

crates/cairo-lang-sierra/src/extensions/modules/circuit.rs line 170 at r1 (raw file):

Previously, orizi wrote…

Same

Done.

[orizi]

Reviewed 2 of 2 files at r5, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ilyalesokhin-starkware)

---

crates/cairo-lang-sierra/src/extensions/modules/circuit.rs line 175 at r5 (raw file):

}

/// libfunc for Initializing the input data for running an instance of the circuit.

Suggestion:

/// Libfunc for initializing the input data for running an instance of the circuit.

[ilyalesokhin-starkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @orizi)

---

crates/cairo-lang-sierra/src/extensions/modules/circuit.rs line 175 at r5 (raw file):

}

/// libfunc for Initializing the input data for running an instance of the circuit.

Done.

[orizi]

Reviewed 1 of 1 files at r6, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ilyalesokhin-starkware)