Added nightly runs for rust nightly versions update failure. #5541
Conversation
orizi
force-pushed
the
orizi/nightly-checks
branch
from
99d083b to
66c73b3
Compare
Additional fixes to make the nightlies pass properly.
orizi
force-pushed
the
orizi/nightly-checks
branch
from
66c73b3 to
9fadef6
Compare
There was a problem hiding this comment.
Reviewed 7 of 7 files at r1.
Reviewable status: all files reviewed (commit messages unreviewed), 1 unresolved discussion (waiting on @orizi and @yuvalsw)
scripts/rust_fmt.sh line 3 at r1 (raw file):
#!/bin/bash cargo +nightly-2024-04-23 fmt --all -- "$@"
The ci.yml still use 04/23 nightly in several places, however the ci pass so I'm not sure it has any effect.
There was a problem hiding this comment.
Reviewable status: all files reviewed (commit messages unreviewed), 1 unresolved discussion (waiting on @gilbens-starkware and @yuvalsw)
scripts/rust_fmt.sh line 3 at r1 (raw file):
Previously, gilbens-starkware (Gil Ben-Shachar) wrote…
The
ci.ymlstill use 04/23 nightly in several places, however the ci pass so I'm not sure it has any effect.
It is set by the toolchain field in the ci yml itself, I changed it since it is used in both now.
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @yuvalsw)
Additional fixes to make the nightlies pass properly.
This change is