-
Notifications
You must be signed in to change notification settings - Fork 598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc/remove trivia from signatures #6393
Doc/remove trivia from signatures #6393
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 4 files at r1.
Reviewable status: 0 of 8 files reviewed, 1 unresolved discussion (waiting on @Arcticae, @Draggu, @orizi, @piotmag769, and @wawel37)
crates/cairo-lang-doc/src/tests/test.rs
line 230 at r1 (raw file):
output.insert( "Item #".to_string() + &item_number.to_string(), format!("{}\n{}", signature, documentation.unwrap_or_default()),
can you submit signature and docs as separate sections, like Item signature #0
& Item documentation #0
? This way it'd be much more readable when you're reading just the fixture
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 8 files reviewed, 1 unresolved discussion (waiting on @Arcticae, @Draggu, @mkaput, @orizi, and @piotmag769)
crates/cairo-lang-doc/src/tests/test.rs
line 230 at r1 (raw file):
Previously, mkaput (Marek Kaput) wrote…
can you submit signature and docs as separate sections, like
Item signature #0
&Item documentation #0
? This way it'd be much more readable when you're reading just the fixture
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 7 files at r2, 4 of 4 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Arcticae, @Draggu, @orizi, and @piotmag769)
This change is