Enabled bounded-int abs optimization in i128 mul.
#6417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 25, 2024
gilbens-starkware
approved these changes
Sep 25, 2024
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @orizi)
orizi
force-pushed
the
spr/main/e0019c30
branch
from
ef344e1 to
83d6d86
Compare
orizi
force-pushed
the
spr/main/8d2ec222
branch
2 times, most recently
from
986e2e5 to
f2951b8
Compare
commit-id:8d2ec222 fixup! Enabled bounded-int `abs` optimization in i128 mul.
orizi
force-pushed
the
spr/main/8d2ec222
branch
from
f2951b8 to
f229ff8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack:
absoptimization in i128 mul. #6417 ⬅