added associated type args in semantic #6763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomerStarkware
requested review from
orizi,
mkaput,
Arcticae,
Draggu,
piotmag769 and
integraledelebesgue
as code owners
|
This change is |
orizi
approved these changes
Nov 28, 2024
There was a problem hiding this comment.
Reviewed 16 of 16 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Arcticae, @Draggu, @integraledelebesgue, @mkaput, and @piotmag769)
mkaput
approved these changes
Nov 28, 2024
There was a problem hiding this comment.
Reviewed 2 of 16 files at r1, all commit messages.
Reviewable status:
mkaput
approved these changes
Nov 28, 2024
There was a problem hiding this comment.
Reviewable status:
mkaput
removed request for
Arcticae,
piotmag769,
Draggu and
integraledelebesgue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.