Use Star Impl Handling

[Tomer-StarkWare]

No description provided.

[reviewable-StarkWare]

This change is 

[orizi]

Reviewed 1 of 4 files at r1, all commit messages.
Reviewable status: 1 of 4 files reviewed, 2 unresolved discussions (waiting on @gilbens-starkware and @Tomer-StarkWare)

---

crates/cairo-lang-semantic/src/expr/semantic_test_data/use line 1263 at r1 (raw file):

//! > ==========================================================================

//! > Testing use star impl import

Suggestion:

//! > Testing use star import trait by impl.

---

crates/cairo-lang-semantic/src/expr/semantic_test_data/use line 1321 at r1 (raw file):

//! > ==========================================================================

//! > Testing use star struct import with trait

Suggestion:

//! > Testing use star struct import import trait.

[Tomer-StarkWare]

Reviewable status: 1 of 4 files reviewed, 2 unresolved discussions (waiting on @gilbens-starkware and @orizi)

---

crates/cairo-lang-semantic/src/expr/semantic_test_data/use line 1263 at r1 (raw file):

//! > ==========================================================================

//! > Testing use star impl import

Done.

---

crates/cairo-lang-semantic/src/expr/semantic_test_data/use line 1321 at r1 (raw file):

//! > ==========================================================================

//! > Testing use star struct import with trait

Done.

[orizi]

Reviewed 1 of 4 files at r2, all commit messages.
Reviewable status: 1 of 4 files reviewed, 1 unresolved discussion (waiting on @gilbens-starkware and @Tomer-StarkWare)

---

crates/cairo-lang-semantic/src/items/imp.rs line 1365 at r2 (raw file):

            uninferred_impls.insert(curr_uniferred_impl);
        }
    }

Suggestion:

    for (user_module, containing_module) in &db.priv_module_use_star_modules(module_id).accessible {
        if let Ok(star_module_uninferred_impls) = module_impl_ids(db, *user_module, *containing_module) {
            uninferred_impls.extend(star_module_uninferred_impls);
        }
    }

[orizi]

Reviewable status: 1 of 4 files reviewed, 2 unresolved discussions (waiting on @gilbens-starkware and @Tomer-StarkWare)

---

crates/cairo-lang-semantic/src/expr/semantic_test_data/use line 1321 at r2 (raw file):

//! > ==========================================================================

//! > Testing use star struct import trait.

Suggestion:

//! > struct import impl through use star.

[Tomer-StarkWare]

Reviewable status: 1 of 4 files reviewed, 2 unresolved discussions (waiting on @gilbens-starkware and @orizi)

---

crates/cairo-lang-semantic/src/expr/semantic_test_data/use line 1321 at r2 (raw file):

//! > ==========================================================================

//! > Testing use star struct import trait.

Done.

---

crates/cairo-lang-semantic/src/items/imp.rs line 1365 at r2 (raw file):

            uninferred_impls.insert(curr_uniferred_impl);
        }
    }

Done.

[orizi]

Reviewed 1 of 4 files at r2, 3 of 3 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @gilbens-starkware)

[orizi]

Reviewed 4 of 4 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Arcticae, @Draggu, @gilbens-starkware, @integraledelebesgue, @mkaput, @piotmag769, and @Tomer-StarkWare)

---

crates/cairo-lang-language-server/tests/test_data/code_actions/missing_trait.txt line 111 at r4 (raw file):

        x.some_me<caret>thod();
Title: Import super::ATrait1
Add new text: "use super::ATrait1;

discuss with gil.

[orizi]

Reviewed 6 of 6 files at r6, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Arcticae, @Draggu, @gilbens-starkware, @integraledelebesgue, @mkaput, and @piotmag769)