Refactored bounded_int_trim.

[orizi]

Not updating the given range.
Splitting into bounded_int_trim_min and bounded_int_trim_max.

[reviewable-StarkWare]

This change is 

[liorgold2]

Reviewed 8 of 8 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @orizi)

---

corelib/src/internal/bounded_int.cairo line 129 at r1 (raw file):

    }
    pub impl Max<T, const MIN: felt252, const MAX: felt252> of super::TrimMaxHelper<T> {
        type Target = super::BoundedInt<MIN, MAX>;

Can't you use MAX - 1 (where MAX is taken from another unrelated trait)? Why do you need all these helpers?

---

crates/cairo-lang-sierra/src/extensions/modules/bounded_int.rs line 397 at r1 (raw file):

    const STR_ID: &'static str =
        if ABOVE { "bounded_int_trim_max" } else { "bounded_int_trim_min" };

Maybe rename ABOVE to IS_MAX? To be consistent with the min, max naming?

[orizi]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @liorgold2)

---

corelib/src/internal/bounded_int.cairo line 129 at r1 (raw file):

Previously, liorgold2 wrote…

Can't you use MAX - 1 (where MAX is taken from another unrelated trait)? Why do you need all these helpers?

hmm - probably in some way - but probably not for this PR.
additionally, calculations of generic params to be used as generic args is problematic (and definitely not supported on 2.10.* and only partially on main)

---

crates/cairo-lang-sierra/src/extensions/modules/bounded_int.rs line 397 at r1 (raw file):

Previously, liorgold2 wrote…

Maybe rename ABOVE to IS_MAX? To be consistent with the min, max naming?

Done.

[liorgold2]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @orizi)

[liorgold2]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @orizi)