Skip to content

Commit

Permalink
Fix comments
Browse files Browse the repository at this point in the history
  • Loading branch information
Sia Zhong Qing committed Apr 15, 2024
1 parent 7b6efbf commit 6cdf018
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 11 deletions.
8 changes: 2 additions & 6 deletions docs/DeveloperGuide.md
Original file line number Diff line number Diff line change
Expand Up @@ -319,8 +319,8 @@ Recalling that we also have a message box to inform the result of the actions ta
* Cons: JSON files can be difficult to amend and maintain.

* **Alternative 2 (previously implemented)**: Store the Related List as a .txt file.
* Pros: Easier to edit, maintain, and implement.
* Cons: Not secure, and save and load implementation is exposed outside the NetConnect model.
* Pros: Easier to edit, and implement.
* Cons: Harder to maintain as there will be multiple files to be used by our application. Save and load implementation is also exposed outside the NetConnect model.

* **Alternative 3**: Store Relations as another field in every person. A relate command would add the opposing contact to both persons provided.
* Pros: Easy to understand as a user. Querying of contacts will also be fast as the relations are stored within the same contact.
Expand Down Expand Up @@ -577,10 +577,6 @@ The following activity diagram summarizes what happens when a user executes a ne

_{more aspects and alternatives to be added}_

### \[Proposed\] Data archiving

_{Explain here how the data archiving feature will be implemented}_

--------------------------------------------------------------------------------------------------------------------

## **Documentation, logging, testing, configuration, dev-ops**
Expand Down
4 changes: 2 additions & 2 deletions docs/diagrams/RelateActivityDiagram.puml
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@ start
:User executes relate command;

if () then ([else])
:Display error message;
:Show error message;
else ([two numeric IDs provided])
if () then ([else])
:Display error message;
:Show error message;
else ([Both IDs exist])
:Relate both profiles to each other;
:Display both profiles that are related;
Expand Down
2 changes: 1 addition & 1 deletion docs/diagrams/ShowRelatedActivityDiagram.puml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ start


if () then ([else])
:Display error message;
:Show error message;
else ([One valid number (Integer and greater than 0) provided])
if () then ([has related profile(s)])
:Display list of related profiles;
Expand Down
4 changes: 2 additions & 2 deletions docs/diagrams/UnrelateActivityDiagram.puml
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@ start
:User executes unrelate command;

if () then ([else])
:Display error message;
:Show error message;
else ([two numeric IDs provided])
if () then ([else])
:Display error message;
:Show error message;
else ([Both IDs exist])
:Unrelate both profiles to each other;
:Display both profiles that have been unrelated;
Expand Down

0 comments on commit 6cdf018

Please sign in to comment.