Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rtm-ros-robot-interface.l]fix bug in :cmd-vel-cb #1101

Merged
merged 3 commits into from
May 10, 2021

Conversation

Naoki-Hiraoka
Copy link
Contributor

This Pull Request fixes a bug in :cmd-vel-cb of rtm-ros-robot-interface.

The unit of AutoBlancerService::goVelocity is deg/s, not rad/s
https://github.com/fkanehiro/hrpsys-base/blob/e98cf26c12eeeda761cef5b836e9640d68bf7387/idl/AutoBalancerService.idl#L345

Copy link
Contributor

@YutaKojio YutaKojio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Naoki-Hiraoka
Copy link
Contributor Author

@k-okada バグfixですので,mergeをお願いいたします.テストを追加するのは難しいと考えています.

@k-okada k-okada merged commit fe1c671 into start-jsk:master May 10, 2021
@Naoki-Hiraoka
Copy link
Contributor Author

ありがとうございます.

@Naoki-Hiraoka Naoki-Hiraoka deleted the fix-cmd-vel branch May 10, 2021 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants