Add "toolbar" buttons for some list actions #1673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Forgot to mention. "Play selected" seems to be broken, also on my "production" environment, so not related to these changes. |
|
Mentioned issue above with "Play selected" actually was a long standing bug when only having a single item selected. Fixed in #1674 |
WithoutPants
approved these changes
Aug 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Personal pet peeve is having to click twice to start playback of selected scenes (once to open the actions menu and once more for "Play selected". This while the edit and delete buttons always appear right away after selecting a scene while I use those much less. So this fixes it my adding a play button next to the edit and delete buttons.
Also when adding images to a gallery for the first time I really had to search for how to do it. Obviously there is the
Addtab, but after selecting some images I had to search how to actually save it, and apparently that's also in the...menu. But not anymore, as now it's also available in the toolbar. And applied the same for removing images from the gallery. So both are now available as button next to the edit/delete buttons.This works by adding an optional
iconproperty to the "otherOperations" list. When an icon is set the button will be shown. OptionallybuttonVariantcan be provided as well, which is used to make "Remove from gallery" button red (/applydangervariant).