-
-
Notifications
You must be signed in to change notification settings - Fork 827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Handy integration #2555
Improve Handy integration #2555
Conversation
First impression:
If I notice anything else I'll let you know but well done! |
I haven't had a chance to test this pr yet (tomorrow I'm going to try and finally learn how to create docker images from GitHub repositories) but I figured it might help to know that
I've been deleting videos + funscripts ever since the pr hit docker without encountering this error. I also tested it out just now by connecting my handy, playing a scripted video in one tab then deleting it from another tab and it didn't throw up any errors. |
I've updated to address the leftover issues I found. I've also bumped up the opacity and the state will also stay on-screen until the device is ready, in the event that the player is started before the script is uploaded. |
Interactive Options
section in the Interface Settings:When not connected, the connect button allows attempting to reconnection.
When connected, there is a Sync button which calculates the server offset.
This indicates when an interactive script is still being uploaded. It is only shown when a Handy key is configured and when the scene is interactive.
Resolves #2539 - the initial lead time was due to recalculating the server offset time before uploading the script, which is time consuming and mostly unnecessary.
Other issues that I identified that are yet to be addressed in this PR:
does not signal to stop the device when navigating to another pageneeds to handle looping videosneeds to handle next/previous navigationwhenautoplay
is true and the scene is interactive, it should finish uploading the funscript before starting playback