-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add UMD bundle for @xstate/react. #1738
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
3267d19
Add UMD bundle for @xstate/react.
dimitardanailov b4f8dd4
Changeset has info about: Add UMD bundle for @xstate/react.
dimitardanailov be0e92d
Update .changeset/proud-clouds-explain.md
davidkpiano b72a9b5
@react/composition-api doesn't exist.
dimitardanailov 1fd3205
Each CDN link has an additional prefix: .umd
dimitardanailov bf81cd5
Each link has an additional prefix: .umd
dimitardanailov c7422c2
Comment by: Andarist -> in v5 we won't be generating unminified UMD
dimitardanailov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
'@xstate/react': minor | ||
--- | ||
|
||
Added UMD bundle. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
import { terser } from 'rollup-plugin-terser'; | ||
import typescript from 'rollup-plugin-typescript2'; | ||
|
||
function createTSCofig() { | ||
return typescript({ | ||
tsconfigOverride: { | ||
compilerOptions: { | ||
declaration: false | ||
} | ||
} | ||
}); | ||
} | ||
|
||
function createUmdConfig({ input, output: file, name }) { | ||
return { | ||
input, | ||
output: { | ||
file, | ||
format: 'umd', | ||
name, | ||
globals: { | ||
xstate: 'XState', | ||
'@xstate/react': 'XStateReact' | ||
} | ||
}, | ||
plugins: [createTSCofig(), terser({ include: [/^.+\.min\.js$/] })] | ||
}; | ||
} | ||
|
||
export default [ | ||
createUmdConfig({ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. in v5 we won't be generating unminified UMD bundles, so let's drop this for now |
||
name: 'XStateReact', | ||
input: 'src/index.ts', | ||
output: 'dist/xstate-react.umd.min.js' | ||
}), | ||
createUmdConfig({ | ||
name: 'XStateReactFSM', | ||
input: 'src/fsm.ts', | ||
output: 'dist/xstate-react-fsm.umd.min.js' | ||
}) | ||
]; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as mentioned in the other comment - let's just focus on producing minified bundles