Make updated context available to invokes #4351
Conversation
🦋 Changeset detectedLatest commit: 35ab007 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 35ab007:
|
| @@ -63,10 +63,10 @@ export function fromCallback<TEvent extends EventObject, TInput = unknown>( | |||
| const logic: CallbackActorLogic<TEvent, TInput> = { | |||
| config: invokeCallback, | |||
| start: (_state, { self, system }) => { | |||
| system._relay(self, self, { type: XSTATE_INIT }); | |||
There was a problem hiding this comment.
this was super confusing because XSTATE_INIT is a special event and yet this "custom" logic was sending the same type to itself manually
packages/core/src/stateUtils.ts
Outdated
| @@ -1191,9 +1213,9 @@ function enterStates( | |||
| stateNodeToEnter.output | |||
| ? resolveOutput( | |||
| stateNodeToEnter.output, | |||
| currentState.context, | |||
| nextState.context, // TODO: this was likely buggy, write a test case that proved it | |||
There was a problem hiding this comment.
TODO: I need to look into this before landing this
There was a problem hiding this comment.
yep, this was buggy - I'm gonna add a test case for this in a sec: https://stackblitz.com/edit/typescript-yg1pad?file=index.ts
| @@ -424,11 +415,14 @@ describe('predictableExec', () => { | |||
| entry: sendTo('myChild', { type: 'KNOCK_KNOCK' }), | |||
| invoke: { | |||
| id: 'myChild', | |||
| src: fromCallback(({ receive }) => { | |||
There was a problem hiding this comment.
Currently, a callback actor couldn't be used here for this test case because the event sent from an entry action to an invoked actor is being received by it before a callback actor has a chance to setup listeners.
It's a timing issue that we should fix but that's outside of the scope of this PR.
| entry: assign(({ system }) => { | ||
| expect(system!.get('test')).toBeDefined(); | ||
| }) |
There was a problem hiding this comment.
well, this is an ability that we'd "lose" if we gonna land this PR. I think it's fine though because this:
invoke: { src: logic, id: 'myId' },
entry: sendTo('myId', event)is way more useful and probable than:
invoke: { src: logic, systemId: 'mySystemId' },
entry: sendTo(({ system }) => system.get('mySystemId'), event)Note that this whole problem is only relevant when an entry action tries to grab the actor that is just about to be invoked by the very same state from the system. As showcased by the test adjustment - the actor becomes available in the system right after entry+invoke on a single state are resolved
Entry actions are executed first (before invokes) so |
* Call actions while executing algorithm and not at the end of it * Make updated context available to invokes * add a test case for delayed events * add a test case for done.state output * add changeset
* Call actions while executing algorithm and not at the end of it * Make updated context available to invokes * add a test case for delayed events * add a test case for done.state output * add changeset
No description provided.