filtering out suppressed data before some of the checks #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bjoern-Rapp
previously approved these changes
Jan 21, 2025
|
Bjoern-Rapp
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patches version, publishing to Pypi, new version: 1.2.9
Closes #171
This PR is to make the validations less aggressive, when handeling suppressed cells. The goal is to ignore the suppressed data during validation by setting the cells to NA before doing validations. It should however not affect the original data.
The use-case presented was that users wanted to input empty stings "", into cells that were suppressed, to guarantee that they would not end up published. This PR should make it possible, that validate() should not complain about this.