Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Network to Cluster Config #67

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Added Network to Cluster Config #67

wants to merge 3 commits into from

Conversation

karticn-google
Copy link
Contributor

@statmike please review this request.

@statmike
Copy link
Owner

as we talked about, these three changes:

  • separate line for import of google.cloud.compute
  • add spaces before/after = signs for readability
  • add logic check for default network before checking for ALLOYDB_NETWORK like is already used in the cluster config

@karticn-google
Updated the following:
e571224 
1. Moved google cloud compute engine import to a separate section.
2. Adjusted '=' spacing.
3. Check ALLOYDB_NETWORK value before Network Validation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@karticn-google @statmike