Skip to content

Commit

Permalink
chore: suggest defaults for group fields
Browse files Browse the repository at this point in the history
  • Loading branch information
mariatsji committed Dec 4, 2024
1 parent 68c3c9e commit 0772c06
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 6 deletions.
12 changes: 6 additions & 6 deletions apis/user/v1alpha1/group_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ type GroupParameters struct {
//+optional
//+kubebuilder:default="true"
//+kubebuilder:validation:Pattern=`^(true|false)$`
Active *string `json:"active,omitempty"`
Active *string `json:"active"`
// GroupID is the group ID (known as Name in the GUI).
//+kubebuilder:validation:MinLength=1
//+kubebuilder:validation:MaxLength=64
Expand All @@ -40,11 +40,11 @@ type GroupParameters struct {
// GroupName is the group name (known as Description in the GUI).
//+optional
//+kubebuilder:validation:MaxLength=64
GroupName *string `json:"groupName,omitempty"`
GroupName *string `json:"groupName"`
// LDAPEnabled determines whether LDAP authentication is enabled for members of this group.
//+optional
//+kubebuilder:default=false
LDAPEnabled *bool `json:"ldapEnabled,omitempty"`
LDAPEnabled *bool `json:"ldapEnabled"`
//+optional
// LDAPGroup us the group's name from the LDAP system.
LDAPGroup *string `json:"ldapGroup,omitempty"`
Expand All @@ -63,13 +63,13 @@ type GroupParameters struct {
LDAPUserDNTemplate *string `json:"ldapUserDNTemplate,omitempty"`
//+optional
//+kubebuilder:default={ALL}
S3EndpointsHTTPS []string `json:"s3endpointshttp,omitempty"`
S3EndpointsHTTPS []string `json:"s3endpointshttp"`
//+optional
//+kubebuilder:default={ALL}
S3EndpointsHTTP []string `json:"s3endpointshttps,omitempty"`
S3EndpointsHTTP []string `json:"s3endpointshttps"`
//+optional
//+kubebuilder:default={ALL}
S3WebsiteEndpoints []string `json:"s3websiteendpoints,omitempty"`
S3WebsiteEndpoints []string `json:"s3websiteendpoints"`
}

// GroupObservation are the observable fields of a Group.
Expand Down
1 change: 1 addition & 0 deletions package/crds/user.cloudian.crossplane.io_groups.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ spec:
pattern: ^[A-Za-z0-9_-]*$
type: string
groupName:
default: ""
description: GroupName is the group name (known as Description
in the GUI).
maxLength: 64
Expand Down

0 comments on commit 0772c06

Please sign in to comment.