Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sdk): introduce User type separate from UserID type #152

Merged
merged 6 commits into from
Feb 20, 2025

Conversation

tenstad
Copy link
Member

@tenstad tenstad commented Feb 20, 2025

  • fixing the // FIXME: Introduce UserId struct and enrich User
  • enbales enriching the User struct with additional fields
  • removes the internalUser type (was only used to set a default UserType - not needed as UserType is now made userfacing)

@tenstad tenstad requested review from erikgb and mariatsji and removed request for erikgb February 20, 2025 14:45
@tenstad tenstad changed the title feat: add canonical user id to status chore: cleanup user to enable additional fields Feb 20, 2025
@tenstad tenstad force-pushed the canonicaluserid branch 2 times, most recently from 4bc2e78 to d470e35 Compare February 20, 2025 16:37
@tenstad tenstad changed the title chore: cleanup user to enable additional fields chore(sdk): introduce User type separate from UserID type Feb 20, 2025
Copy link
Member

@erikgb erikgb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tenstad tenstad merged commit 4cb8806 into statnett:main Feb 20, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants