feat: add cloudian-sdk with CRUD on group #20

mariatsji · 2024-11-21T11:51:53Z

This introduces cloudian-SDK with CRUD for groups

internal/sdk/cloudian/sdk.go

internal/sdk/cloudian/sdk_test.go

refactor: shorten expression Co-authored-by: Amund Tenstad <[email protected]>

…tions

internal/sdk/cloudian/sdk.go

refactor: rename MkClient to NewClient Co-authored-by: Amund Tenstad <[email protected]>

fix: error check in list users Co-authored-by: Amund Tenstad <[email protected]>

fix: handle users errors logic Co-authored-by: Amund Tenstad <[email protected]>

internal/sdk/cloudian/sdk.go

internal/sdk/cloudian/sdk_test.go

var assignment best practice Co-authored-by: Amund Tenstad <[email protected]>

internal/sdk/cloudian/sdk_test.go

internal/sdk/cloudian/sdk.go

erikgb

LGTM

to get this merged

mariatsji added 10 commits November 21, 2024 10:29

feat: add cloudian-sdk with CRUD on group

47bc77d

refactor: reuse http.Client in sdk.go

57cf3f6

format: gofmt -s sdk.go

6c876a6

lint: remove decode-method, trust user

f4632df

lint: cloudian sdk inline status code check

f815199

lint: cloudian sdk insert space after comment slashes

05284af

lint: cloudian sdk close all response bodys

c80b2dc

lint: cloudian sdk annotate json structs

774bd09

refactor: cloudian sdk refer to http package verbs

ee23dca

lint: cloudian sdk add explicit http context

e130ccb

mariatsji requested review from tenstad and erikgb November 21, 2024 12:43

tenstad requested changes Nov 22, 2024

View reviewed changes

mariatsji and others added 12 commits November 22, 2024 08:49

refactor: adhere golang convension of capitalized abbreviations

ea5cd14

fix: add cloudian base url required env variable

982451d

refactor: sdk cloudian, shorten offset var assignment

171e4f6

refactor: cloudian sdk defer body close and ignore any failure doing so

fbfdbf5

fix: provider-cloudian fix delete user logic failure

36bc3ba

Update internal/sdk/cloudian/sdk.go

3a36ae8

refactor: shorten expression Co-authored-by: Amund Tenstad <[email protected]>

cloudian sdk ignore error check of body close

9ab98f6

refactor: cloudian sdk strip away return types for non-fetching opera…

074b7f8

…tions

refactor: introduce cludian sdk client

768565d

fix: cloudian sdk should not log

a8f26e2

refactor: cloudian sdk common headers function

52cdc12

test: add property test for json marshall roundtrip just for fun

ddd5b78

tenstad previously requested changes Nov 22, 2024

View reviewed changes

mariatsji and others added 4 commits November 22, 2024 14:26

Update internal/sdk/cloudian/sdk.go

1c25a64

refactor: rename MkClient to NewClient Co-authored-by: Amund Tenstad <[email protected]>

Update internal/sdk/cloudian/sdk.go

b93b115

fix: error check in list users Co-authored-by: Amund Tenstad <[email protected]>

Update internal/sdk/cloudian/sdk.go

fbf08f7

fix: handle users errors logic Co-authored-by: Amund Tenstad <[email protected]>

fix: compilation errors after updates

e8db770

mariatsji requested a review from tenstad November 25, 2024 11:44