feat(cloudian-sdk): add cloudian user #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tenstad
reviewed
Dec 20, 2024
tenstad
reviewed
Dec 20, 2024
tenstad
reviewed
Dec 20, 2024
internal/sdk/cloudian/sdk.go
Outdated
Comment on lines
215
to
223
| url := client.baseURL + "/user" | ||
|
|
||
| // We can create an internal type for this json data later, if needed | ||
| jsonData, err := json.Marshal(toInternalUser(user)) | ||
| if err != nil { | ||
| return fmt.Errorf("error marshaling JSON: %w", err) | ||
| } | ||
|
|
||
| req, err := client.newRequest(ctx, url, http.MethodPut, jsonData) |
There was a problem hiding this comment.
Move url to where it's used?
Suggested change
| url := client.baseURL + "/user" | |
| // We can create an internal type for this json data later, if needed | |
| jsonData, err := json.Marshal(toInternalUser(user)) | |
| if err != nil { | |
| return fmt.Errorf("error marshaling JSON: %w", err) | |
| } | |
| req, err := client.newRequest(ctx, url, http.MethodPut, jsonData) | |
| // We can create an internal type for this json data later, if needed | |
| jsonData, err := json.Marshal(toInternalUser(user)) | |
| if err != nil { | |
| return fmt.Errorf("error marshaling JSON: %w", err) | |
| } | |
| url := client.baseURL + "/user" | |
| req, err := client.newRequest(ctx, url, http.MethodPut, jsonData) |
There was a problem hiding this comment.
I kinda like having it as the first var in every exported function. This way we can see at a glance what endpoint we invoke. But I don't have an issue with moving it down..
There was a problem hiding this comment.
come to think of it - the whole var could be inlined. gofmt wants no spaces between that +
Co-authored-by: Amund Tenstad <[email protected]>
erikgb
reviewed
Dec 20, 2024
| return fmt.Errorf("error marshaling JSON: %w", err) | ||
| } | ||
|
|
||
| req, err := client.newRequest(ctx, client.baseURL+"/user", http.MethodPut, jsonData) |
There was a problem hiding this comment.
Why isn't the base URL handled inside the client newRequest?
There was a problem hiding this comment.
would make sense, but perhaps in a separate PR?
There was a problem hiding this comment.
Supporting leaving it be for now and fixing in new PR
tenstad
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.