-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Miracl core #66
Merged
Merged
Miracl core #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bench
Old was: #47 |
This was referenced Sep 4, 2020
Closed
etan-status
added a commit
that referenced
this pull request
Feb 17, 2024
Followup from #66 where we switched from Milagro to MIRACL Core. The script to prepare C sources was not yet renamed. Doing now.
etan-status
added a commit
that referenced
this pull request
Feb 17, 2024
Followup from #66 where we switched from Milagro to MIRACL Core. The main module was not yet renamed. Doing now. Should not break clients as the module is not usually directly imported.
etan-status
added a commit
that referenced
this pull request
Feb 17, 2024
Followup from #66 where we switched from Milagro to MIRACL Core. The script to prepare C sources was not yet renamed. Doing now.
etan-status
added a commit
that referenced
this pull request
Feb 17, 2024
Followup from #66 where we switched from Milagro to MIRACL Core. The main module was not yet renamed. Doing now. Should not break clients as the module is not usually directly imported.
etan-status
added a commit
that referenced
this pull request
Feb 17, 2024
Followup from #66 where we switched from Milagro to MIRACL Core. The internal constant / pragma for importing / exporting were not yet renamed. Doing now.
etan-status
added a commit
that referenced
this pull request
Feb 17, 2024
Followup from #66 where we switched from Milagro to MIRACL Core. The internal constants / pragma for importing / exporting were not yet renamed. Doing now.
etan-status
added a commit
that referenced
this pull request
Feb 17, 2024
Followup from #66 where we switched from Milagro to MIRACL Core. The internal documentation was not fully updated for Miracl. Doing now.
etan-status
added a commit
that referenced
this pull request
Feb 17, 2024
Followup from #66 where we switched from Milagro to MIRACL Core. The internal constants / pragma for importing / exporting were not yet renamed. Doing now.
etan-status
added a commit
that referenced
this pull request
Feb 17, 2024
Followup from #66 where we switched from Milagro to MIRACL Core. The internal documentation was not fully updated for Miracl. Doing now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches the backend from apache/amcl (which now points to https://github.com/apache/incubator-milagro-crypto-c) to miracl/core which recently changed to Apache license.
Backends and their differences are highlighted here: https://notes.status.im/nim-bls-curve-backends
In particular:
sqrt
function is constant-time as required by the IETF Hash-to-curve draftChanges:
setx
procedure used in fromHex/fromBytes serialization had to be changed to the new sqrt API.On G1 in particular, the QR procedure is preferred over the jacobi symbol to test if a field element is square
so that we can benefit from the fast sqrt hint.
Not done:
Cleanup the old submodule