Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support adressing any nimbus-eth2
BeaconState
member, 32-bit wideindices are not enough.
BeaconState
requires 5 levels of depth;VALIDATOR_REGISTRY_LIMIT
for thevalidators
array requires 40 levelsfor the contents plus 2 levels for
len
and the root. Another 4 levelsare required for
Validator
. This means that 52-bit indices are needed.Extending to
uint64
should provide enough leeway without requiringfurther implementation adjustments.