GeneralStateTest runner #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coffeepots
approved these changes
Sep 10, 2018
zah
approved these changes
Sep 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an initial cut at https://github.com/status-im/nimbus/issues/113 which gets around 440 test fixtures correct, out of around 2500.
The remaining ones depend either on
CALLinstructions,CREATEinstructions, create a contract some other way, use unimplemented precompiled contracts (https://github.com/status-im/nimbus/issues/122 tracks that), have multiple data payload fields, trigger an out of memory condition in the VM, or have some other issue.It's a refactoring away from an initial implementation of https://github.com/status-im/nimbus/issues/130 but I wanted to keep the issue #113 fix initially locally contained for clarify of what, exactly, it changes.