Triggered write event for kvt #2351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
details: filter* => delta* roFilter => balancer
why: Might eventually fail if re-centring is blocked. Some logic will be added in subsequent patch sets.
why: All previously used CFs must be declared when re-opening an existing database.
…eters why: Opening a set column families (with different open options) must span at least the ones that are already on disk.
why: This allows to save data from a guest application (think `KVT`) to get synced with the write cycle so the guest and `Aristo` save all atomically.
why: Some systems (i.p `fluffy` and friends) use the `Aristo` memory backend emulation and do not link against rocksdb when building the application. So this should fix that problem.
arnetheduck
reviewed
Jun 13, 2024
| @@ -28,6 +28,7 @@ type | |||
| Ooops | |||
| AristoDbMemory ## Memory backend emulator | |||
| AristoDbRocks ## RocksDB backend | |||
| AristoDbDualRocks ## Dual RocksDB backends for `Kvt` and `Aristo` | |||
There was a problem hiding this comment.
let's not add another backend - we should be running tests in the environment exactly how they will appear in production and this looks like a trap for synchronization bugs because of the non-atomicity between updates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.