Beacon sync bookkeeping update and bug fix #3051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
details: Instead of keeping track in `borrowed` of the sum of a set of blocks fetched from the `unprocessed` list, the particular ranges details are stored. When committing a particular range, the range itself (rather then its length) is removed from the `borrowed` data. why: The function `blocksUnprocAmend()`) may produce a race condition, so it was re-implemented as `blocksUnprocAppend()` considering range overlaps with borrowed.
why: The `borrowed` data structure can be fully maintained with the `blocksUnprocXxx()` functions.
why: Was previously deleted after importing blocks although it is not needed anymore after blocks have been assembled using bodies fetched over the ethXX network.
why: Some error exit directives missed some clean up leaving the blocks list with empty/stale block bodies.
why: There is not much one can do. Typically, this type of error is due to a switch to a different canonical chain. When this happens, the block batch is expected to be relatively short as the cause for a chain switch is an RPC instruction. This in turn is effective if some of the blocks on the `FC` database are maintained by the `CL`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.