Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VC: Add Missing Command Line Arguments #3803

Open
jclapis opened this issue Jun 27, 2022 · 4 comments
Open

VC: Add Missing Command Line Arguments #3803

jclapis opened this issue Jun 27, 2022 · 4 comments
Labels
VC Issues related to Validator Client
Milestone

Comments

@jclapis
Copy link
Contributor

jclapis commented Jun 27, 2022

I'm testing the new split VC architecture (#3798) and the VC is missing some command line arguments I use for Rocket Pool. Specifically, I'm looking for these three:

--insecure-netkey-password
--doppelganger-detection
--suggested-fee-recipient

The --network flag isn't accepted either, but if the VC pulls network info from the BN then it doesn't need to be there. I'm not sure if that's the case or not so I'll mention it here.

Additionally, these flags should be added so both the BN and the VC support them:

--metrics
--metrics-address
--metrics-port

I assume things like beacon_attestations_sent_total, beacon_blocks_proposed_total, next_action_wait, and beacon_attestation_sent_delay_bucket will come from the VC since it's in charge of attesting, while things like nbc_peers would remain in the BC? It doesn't particularly matter to me where they come from, as long as it's consistent and it works.

@arnetheduck
Copy link
Member

beacon_attestations_sent_total

Some of these will likely be present in both VC and BN given the BN can operate some keys whiles the VC does the rest (ie the BN can still host an "internal" VC regardless if the API is used)

@arnetheduck
Copy link
Member

See also #3683, #3680

@arnetheduck arnetheduck added the VC Issues related to Validator Client label Jun 27, 2022
@tersec
Copy link
Contributor

tersec commented Jul 27, 2022

#3877 adds doppelganger detection and #3915 addresses the metrics.

@zah zah added this to the v22.8.0 milestone Aug 11, 2022
@zah
Copy link
Contributor

zah commented Aug 16, 2022

The validator client does not connect to the Ethereum P2P network, so the option --insecure-netkey-password is not relevant for it. The network information is indeed pulled from the connected beacon node. #3976 adds the last missing command-line options (--suggested-fee-recipient).

Currently, the validator client supports some of the beacon node metrics, but beacon_blocks_proposed_total and next_action_wait in particular are still missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
VC Issues related to Validator Client
Projects
None yet
Development

No branches or pull requests

4 participants