Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keymanager API for the validator client #3976

Merged
merged 5 commits into from
Aug 19, 2022

Conversation

zah
Copy link
Contributor

@zah zah commented Aug 16, 2022

Also adds support for remote keystores and the --suggested-fee-recipient option in the validator client

@github-actions
Copy link

github-actions bot commented Aug 17, 2022

Unit Test Results

       12 files  ±0       860 suites  ±0   1h 23m 35s ⏱️ + 17m 29s
  1 978 tests +3    1 831 ✔️ +3  147 💤 ±0  0 ±0 
10 610 runs  +9  10 420 ✔️ +9  190 💤 ±0  0 ±0 

Results for commit 8f12f64. ± Comparison against base commit d3dbfd6.

♻️ This comment has been updated with latest results.

@zah zah force-pushed the validator-client-keymanager-rebased branch from 689d81a to 7b85247 Compare August 17, 2022 10:42
@zah zah merged commit fca20e0 into unstable Aug 19, 2022
@zah zah deleted the validator-client-keymanager-rebased branch August 19, 2022 10:30
etan-status added a commit that referenced this pull request Jun 4, 2023
Since #3976, CORS functionality is broken. Fix it to work again:

- Use `--rest-allowed-origin` instead of `--keymanager-allowed-origin`
  to specify CORS `Access-Control-Allow-Origin` header for beacon-APIs.

- Actually pass CORS config to `nim-presto` once more.
tersec pushed a commit that referenced this pull request Jun 4, 2023
Since #3976, CORS functionality is broken. Fix it to work again:

- Use `--rest-allowed-origin` instead of `--keymanager-allowed-origin`
  to specify CORS `Access-Control-Allow-Origin` header for beacon-APIs.

- Actually pass CORS config to `nim-presto` once more.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant