Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nimbus v22.12.0 doesn't recognize --log-level={trace,debug,info,notice,warn,error,fatal} #4500

Closed
tersec opened this issue Jan 13, 2023 · 2 comments

Comments

@tersec
Copy link
Contributor

tersec commented Jan 13, 2023

There's a backwards-incompatible regression in --log-level parsing.

Nimbus v22.11.1 recognized all of these:

$ build/nimbus_beacon_node --version
Nimbus beacon node v22.11.1-e4b193-stateofus
Copyright (c) 2019-2023 Status Research & Development GmbH

eth2 specification v1.3.0-alpha.1

Nim Compiler Version 1.2.16 [Linux: amd64]
$ build/nimbus_beacon_node --log-level=trace
... runs ...
$ build/nimbus_beacon_node --log-level=debug
... runs ...
$ build/nimbus_beacon_node --log-level=info
... runs ...
$ build/nimbus_beacon_node --log-level=warn
... runs ...
$ build/nimbus_beacon_node --log-level=notice
... runs ...
$ build/nimbus_beacon_node --log-level=error
... runs ...
$ build/nimbus_beacon_node --log-level=fatal
... runs ...

And with v22.12.0:

$ build/nimbus_beacon_node --version
Nimbus beacon node v22.12.0-f6a5a5-stateofus
Copyright (c) 2019-2023 Status Research & Development GmbH

eth2 specification v1.3.0-alpha.2

Nim Compiler Version 1.6.11 [Linux: amd64]
$ build/nimbus_beacon_node --log-level=info
Invalid value for --log-level. Please specify one of TRACE, DEBUG, INFO, NOTICE, WARN, ERROR or FATAL

and the others show the same error message, then immediately quit.

@zah
Copy link
Contributor

zah commented Jan 13, 2023

Probably caused by the upgrade to Nim 1.6

@tersec
Copy link
Contributor Author

tersec commented Jan 13, 2023

Built v22.12.0 with Nim 1.2 and can confirm that it seems to fix this.

Why would Nim 1.6 have affected this?

zah added a commit that referenced this issue Jan 18, 2023
@zah zah closed this as completed in ae301af Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants