Fix counters in validator monitor totals mode #3332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zah
reviewed
Jan 28, 2022
| epoch = current_epoch, | ||
| validator = id | ||
|
|
||
| if state.next_sync_committee.pubkeys.data.contains(pubkey): |
There was a problem hiding this comment.
How often is this code executed? There are ways to avoid the repeated per-validator linear scans here.
There was a problem hiding this comment.
once per epoch, which is why I didn't bother for now - might do a followup but I want the metrics to be correct first, and this PR is messy enough
arnetheduck
force-pushed
the
val-mon-totals
branch
from
4c5d303 to
a525fe9
Compare
|
Needs rebasing |
The current counters set gauges etc to the value of the _last_ validator to be processed - as the name of the feature implies, we should be using sums instead. * fix missing beacon state metrics on startup, pre-first-head-selection * fix epoch metrics not being updated on cross-epoch reorg
arnetheduck
force-pushed
the
val-mon-totals
branch
from
a525fe9 to
ea26439
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current counters set gauges etc to the value of the last validator
to be processed - as the name of the feature implies, we should be using
sums instead.