Eth1 monitor fixes #3354
Merged
Eth1 monitor fixes #3354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix a resource leak introduced in #3279 * Don't restart the Eth1 syncing proggress from scratch in case of monitor failures during Eth2 syncing. * Switch to the primary operator as soon as it is back online. * Log the web3 credentials in fewer places Other changes: The 'web3 test' command has been enhanced to obtain and print more data regarding the selected provider.
arnetheduck
reviewed
Feb 3, 2022
| # needs to be captured by the onFinalization closure. | ||
| eventBus: AsyncEventBus, | ||
| eth1Monitor: Eth1Monitor): OnFinalizedCallback {.nimcall.} = | ||
| static: doAssert (eventBus is ref) and (eth1Monitor is ref) |
There was a problem hiding this comment.
time to switch to ref Eth1Monitor? I find that style so much more clear than ref object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a resource leak introduced in allow Eth1 monitor to run without genesis_deposit_contract_snapshot.ssz #3279
Don't restart the Eth1 syncing proggress from scratch in case of
monitor failures during Eth2 syncing.
Switch to the primary provider as soon as it is back online.
Log the web3 credentials in fewer places
Other changes:
The 'web3 test' command has been enhanced to obtain and print more
data regarding the selected provider.