Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use JWT when and only when the user specifies a JWT secret explicitly #3786

Merged
merged 1 commit into from
Jun 22, 2022

Conversation

tersec
Copy link
Contributor

@tersec tersec commented Jun 21, 2022

This has some advantages:

  • It allows people to configure and test with JWT without being on a merge testnet.

  • When Prater and mainnet do each get a non-FAR_FUTURE_EPOCH BELLATRIX_FORK_EPOCH but before the merge actually happens, it won't break all those setups using those incompatible Web3 providers; rather, it'll be user choice/action determining this.

  • it de-emphasizes the less useful case of using its CL-autogenerated JWT secret, because generally one's would launch the EL first, and it will generate a secret. For an EL, this is a reasonable approach. For a CL, it seldom makes sense to any default generated JWT secret.

Because of the last point, even in the testnets, there will be virtually no breakage from changing the edge case-semantics of this option.

@github-actions
Copy link

Unit Test Results

     12 files  ±0     857 suites  ±0   1h 8m 36s ⏱️ +19s
1 716 tests ±0  1 664 ✔️ ±0    52 💤 ±0  0 ±0 
9 960 runs  ±0  9 832 ✔️ ±0  128 💤 ±0  0 ±0 

Results for commit 227171c. ± Comparison against base commit 56cd6e2.

@zah zah merged commit 4908ba7 into unstable Jun 22, 2022
@zah zah deleted the opF branch June 22, 2022 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants