Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip execution payload verification for finalized blocks #4591

Merged
merged 1 commit into from
Feb 6, 2023

Conversation

arnetheduck
Copy link
Member

While syncing the finalized portion of the chain, the execution client cannot efficiently sync and most of the time returns SYNCING - in this PR, we use CL-verified optmistic sync as long as the block is claimed to be finalized, only occasionally updating the EL with progress.

Although a peer might lie about what is finalized and what isn't, eventually we'll call the execution client - thus, all a dishonest client can do is delay execution verification slightly. Gossip blocks in particular are never assumed to be finalized.

While syncing the finalized portion of the chain, the execution client
cannot efficiently sync and most of the time returns `SYNCING` - in this
PR, we use CL-verified optmistic sync as long as the block is claimed to
be finalized, only occasionally updating the EL with progress.

Although a peer might lie about what is finalized and what isn't,
eventually we'll call the execution client - thus, all a dishonest
client can do is delay execution verification slightly. Gossip blocks in
particular are never assumed to be finalized.
@github-actions
Copy link

github-actions bot commented Feb 3, 2023

Unit Test Results

         9 files  ±0    1 062 suites  ±0   31m 5s ⏱️ +6s
  3 552 tests ±0    3 315 ✔️ ±0  237 💤 ±0  0 ±0 
15 401 runs  ±0  15 136 ✔️ ±0  265 💤 ±0  0 ±0 

Results for commit 2dd1b24. ± Comparison against base commit bca781b.

@arnetheduck arnetheduck merged commit f3ddea6 into unstable Feb 6, 2023
@arnetheduck arnetheduck deleted the fin-sync-skip branch February 6, 2023 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants