Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sqlite: bump to 3.40.1 #4649

Merged
merged 4 commits into from
Mar 2, 2023
Merged

sqlite: bump to 3.40.1 #4649

merged 4 commits into from
Mar 2, 2023

Conversation

arnetheduck
Copy link
Member

Been a while since we updated

  • fix Defect for 1.6 in kvstore
  • bump nim-eth

@github-actions
Copy link

github-actions bot commented Feb 21, 2023 •
edited
Loading

Unit Test Results

         9 files  ±0    1 065 suites  ±0   32m 37s ⏱️ - 1m 6s
  3 554 tests ±0    3 317 ✔️ ±0  237 💤 ±0  0 ❌ ±0 
15 419 runs  ±0  15 154 ✔️ ±0  265 💤 ±0  0 ❌ ±0 

Results for commit d74c77b. ± Comparison against base commit 2f36f15.

♻️ This comment has been updated with latest results.

@tersec
Copy link
Contributor

tersec commented Feb 22, 2023

The macos/aarch64 Jenkins failure (https://ci.status.im/blue/organizations/jenkins/nimbus-eth2%2Fplatforms%2Fmacos%2Faarch64/detail/PR-4649/2/pipeline) is a new failure mode, at least; it's in all_tests:

[2023-02-22T09:59:04.203Z] [Suite] saveKeystore()
[2023-02-22T09:59:04.203Z]   [OK] Save [LOCAL] keystore after [LOCAL] keystore with same id
[2023-02-22T09:59:04.203Z]   [OK] Save [REMOTE] keystore after [REMOTE] keystore with same id
[2023-02-22T09:59:04.203Z]   [OK] Save [REMOTE] keystore after [LOCAL] keystore with same id
[2023-02-22T09:59:04.203Z]   [OK] Save [LOCAL] keystore after [REMOTE] keystore with same id
[2023-02-22T09:59:04.203Z]   [OK] Save [LOCAL] keystore after [LOCAL] keystore with different id
[2023-02-22T09:59:04.203Z]   [OK] Save [REMOTE] keystore after [REMOTE] keystore with different id
[2023-02-22T09:59:04.203Z]   [OK] Save [LOCAL] keystore after [REMOTE] keystore with different id
[2023-02-22T09:59:04.203Z]   [OK] Save [REMOTE] keystore after [LOCAL] keystore with different id
[2023-02-22T09:59:04.502Z] Wrote test_keymanager_api/genesis.ssz
[2023-02-22T09:59:05.152Z] Wrote test_keymanager_api/bootstrap_node.enr
[2023-02-22T09:59:05.457Z] vendor/nim-libp2p/libp2p/stream/bufferstream.nim(581) main
[2023-02-22T09:59:05.457Z] vendor/nim-libp2p/libp2p/stream/bufferstream.nim(571) NimMain
[2023-02-22T09:59:05.457Z] vendor/nim-libp2p/libp2p/stream/bufferstream.nim(562) PreMain
[2023-02-22T09:59:05.457Z] tests/test_keymanager_api.nim(1480) atmtest_keymanager_apidotnim_Init000
[2023-02-22T09:59:05.457Z] tests/test_keymanager_api.nim(1458) main
[2023-02-22T09:59:05.457Z] vendor/nim-chronos/chronos/asyncfutures2.nim(369) futureContinue
[2023-02-22T09:59:05.457Z] tests/test_keymanager_api.nim(1465) main
[2023-02-22T09:59:05.457Z] tests/test_keymanager_api.nim(289) startBeaconNode
[2023-02-22T09:59:05.457Z] beacon_chain/nimbus_beacon_node.nim(605) init
[2023-02-22T09:59:05.457Z] beacon_chain/networking/eth2_network.nim(2282) createEth2Node
[2023-02-22T09:59:05.457Z] vendor/nimbus-build-system/vendor/Nim/lib/system/assertions.nim(28) raiseAssert
[2023-02-22T09:59:05.457Z] vendor/nimbus-build-system/vendor/Nim/lib/system/fatal.nim(54) sysFatal
[2023-02-22T09:59:05.457Z] [[reraised from:
[2023-02-22T09:59:05.457Z] vendor/nim-libp2p/libp2p/stream/bufferstream.nim(581) main
[2023-02-22T09:59:05.457Z] vendor/nim-libp2p/libp2p/stream/bufferstream.nim(571) NimMain
[2023-02-22T09:59:05.457Z] vendor/nim-libp2p/libp2p/stream/bufferstream.nim(562) PreMain
[2023-02-22T09:59:05.457Z] tests/test_keymanager_api.nim(1480) atmtest_keymanager_apidotnim_Init000
[2023-02-22T09:59:05.457Z] tests/test_keymanager_api.nim(1458) main
[2023-02-22T09:59:05.457Z] vendor/nim-chronos/chronos/asyncfutures2.nim(391) futureContinue
[2023-02-22T09:59:05.457Z] ]]
[2023-02-22T09:59:05.457Z] Error: unhandled exception: /Users/jenkins/workspace/_platforms_macos_aarch64_PR-4649/vendor/nim-chronos/chronos/transports/ipnet.nim(380, 11) `host.family == mask.family`  [AssertionDefect]

Basically same in macos/x86 (https://ci.status.im/blue/organizations/jenkins/nimbus-eth2%2Fplatforms%2Fmacos%2Fx86_64/detail/PR-4649/2/pipeline):

[2023-02-22T10:13:51.002Z] [Suite] saveKeystore()
[2023-02-22T10:13:51.002Z]   [OK] Save [LOCAL] keystore after [LOCAL] keystore with same id
[2023-02-22T10:13:51.002Z]   [OK] Save [REMOTE] keystore after [REMOTE] keystore with same id
[2023-02-22T10:13:51.002Z]   [OK] Save [REMOTE] keystore after [LOCAL] keystore with same id
[2023-02-22T10:13:51.002Z]   [OK] Save [LOCAL] keystore after [REMOTE] keystore with same id
[2023-02-22T10:13:51.002Z]   [OK] Save [LOCAL] keystore after [LOCAL] keystore with different id
[2023-02-22T10:13:51.002Z]   [OK] Save [REMOTE] keystore after [REMOTE] keystore with different id
[2023-02-22T10:13:51.002Z]   [OK] Save [LOCAL] keystore after [REMOTE] keystore with different id
[2023-02-22T10:13:51.389Z]   [OK] Save [REMOTE] keystore after [LOCAL] keystore with different id
[2023-02-22T10:13:51.389Z] Wrote test_keymanager_api/genesis.ssz
[2023-02-22T10:13:52.209Z] Wrote test_keymanager_api/bootstrap_node.enr
[2023-02-22T10:13:52.594Z] vendor/nim-libp2p/libp2p/stream/bufferstream.nim(581) main
[2023-02-22T10:13:52.595Z] vendor/nim-libp2p/libp2p/stream/bufferstream.nim(571) NimMain
[2023-02-22T10:13:52.595Z] vendor/nim-libp2p/libp2p/stream/bufferstream.nim(562) PreMain
[2023-02-22T10:13:52.595Z] tests/test_keymanager_api.nim(1480) atmtest_keymanager_apidotnim_Init000
[2023-02-22T10:13:52.595Z] tests/test_keymanager_api.nim(1458) main
[2023-02-22T10:13:52.595Z] vendor/nim-chronos/chronos/asyncfutures2.nim(369) futureContinue
[2023-02-22T10:13:52.595Z] tests/test_keymanager_api.nim(1465) main
[2023-02-22T10:13:52.595Z] tests/test_keymanager_api.nim(289) startBeaconNode
[2023-02-22T10:13:52.595Z] beacon_chain/nimbus_beacon_node.nim(605) init
[2023-02-22T10:13:52.595Z] beacon_chain/networking/eth2_network.nim(2282) createEth2Node
[2023-02-22T10:13:52.595Z] vendor/nimbus-build-system/vendor/Nim/lib/system/assertions.nim(28) raiseAssert
[2023-02-22T10:13:52.595Z] vendor/nimbus-build-system/vendor/Nim/lib/system/fatal.nim(54) sysFatal
[2023-02-22T10:13:52.595Z] [[reraised from:
[2023-02-22T10:13:52.595Z] vendor/nim-libp2p/libp2p/stream/bufferstream.nim(581) main
[2023-02-22T10:13:52.595Z] vendor/nim-libp2p/libp2p/stream/bufferstream.nim(571) NimMain
[2023-02-22T10:13:52.595Z] vendor/nim-libp2p/libp2p/stream/bufferstream.nim(562) PreMain
[2023-02-22T10:13:52.595Z] tests/test_keymanager_api.nim(1480) atmtest_keymanager_apidotnim_Init000
[2023-02-22T10:13:52.595Z] tests/test_keymanager_api.nim(1458) main
[2023-02-22T10:13:52.595Z] vendor/nim-chronos/chronos/asyncfutures2.nim(391) futureContinue
[2023-02-22T10:13:52.595Z] ]]
[2023-02-22T10:13:52.595Z] Error: unhandled exception: /Users/jenkins/workspace/2_platforms_macos_x86_64_PR-4649/vendor/nim-chronos/chronos/transports/ipnet.nim(380, 11) `host.family == mask.family`  [AssertionDefect]

@tersec
Copy link
Contributor

tersec commented Feb 23, 2023

https://ci.status.im/blue/organizations/jenkins/nimbus-eth2%2Fplatforms%2Fmacos%2Faarch64/detail/PR-4649/4/pipeline has maybe/likely unrelated Jenkins macOS/aarch64 issue:

[2023-02-23T09:52:45.841Z] Building: Nim compiler
[2023-02-23T09:52:51.490Z] Building: install/usr/lib/libunwind.a
[2023-02-23T09:52:56.013Z] Building: install/usr/lib/libbacktrace.a
[2023-02-23T09:53:11.664Z] Building: install/usr/lib/libbacktracenim.a
[2023-02-23T09:54:49.114Z] Building: build/generate_makefile
[2023-02-23T09:54:49.114Z] /Users/jenkins/workspace/_platforms_macos_aarch64_PR-4649/config.nims(13, 11) Error: cannot open file: nimbus-build-system.paths
[2023-02-23T09:54:49.114Z] Build completed successfully: build/generate_makefile
[2023-02-23T09:54:49.114Z] Building: build/deposit_contract
[2023-02-23T09:54:49.114Z] Building: build/resttest
[2023-02-23T09:54:49.114Z] /Users/jenkins/workspace/_platforms_macos_aarch64_PR-4649/config.nims(13, 11) Error: cannot open file: nimbus-build-system.paths
[2023-02-23T09:54:49.114Z] /Users/jenkins/workspace/_platforms_macos_aarch64_PR-4649/config.nims(13, 11) Error: cannot open file: nimbus-build-system.paths
[2023-02-23T09:54:49.114Z] make: *** [resttest] Error 1
[2023-02-23T09:54:49.114Z] make: *** Waiting for unfinished jobs....
[2023-02-23T09:54:49.114Z] make: *** [deposit_contract] Error 1

@arnetheduck arnetheduck enabled auto-merge (squash) February 23, 2023 12:03
@arnetheduck arnetheduck force-pushed the kvstore-defect branch 2 times, most recently from e3648ec to 8fa1f74 Compare February 23, 2023 18:36
@arnetheduck
sqlite: bump to 3.40.1
5cc76df 
Been a while since we updated

* fix Defect for 1.6 in kvstore
* bump nim-eth
@arnetheduck arnetheduck merged commit d9e938e into unstable Mar 2, 2023
@arnetheduck arnetheduck deleted the kvstore-defect branch March 2, 2023 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arnetheduck @tersec