double getBlindedBlock
timeout to 1 second
#4750
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only merge one of #4751 and this
This is from
nimbus-eth2/beacon_chain/validators/validator_duties.nim
Lines 691 to 717 in 17c0eee
But
getBlindedBlock
doesn't directly interact with MEV relays, and is only truly asynchronous at all if someone's using a remote keysigner.getBlindedBlockParts
, rather, is the call which gets the header bid from the MEV relay.The issue is that if the timeout hits after the slashing has been checked in
nimbus-eth2/beacon_chain/validators/validator_duties.nim
Lines 584 to 608 in 17c0eee
it can effectively disable the local EL fallback, because the slashing protection already thinks it's produced a block.
500 milliseconds was somewhat arbitrary, and there hadn't been any timeout in non-remote keysigning setups, so reduce likelihood of this case.