require sync committee supermajority in CI #5085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tersec
force-pushed
the
dev/etan/ci-strictsync
branch
2 times, most recently
from
1d0d3c3 to
089a4a0
Compare
|
There seems to be another issue, possibly around fork boundaries, as now slot 24 is failing, but not due to the VC anymore. |
|
Requires #5089 |
etan-status
force-pushed
the
dev/etan/ci-strictsync
branch
2 times, most recently
from
1cc2d4f to
4301f70
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To better catch problems with sync committee messages in CI, extend local testnet simulation to also verify that each block is signed by a supermajority of the sync committee.
Requires #5083 and #5084