fix LC header production for Deneb #5763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `blob_gas_used` field was not properly populated when constructing Deneb light client data. This is due to #5026 not applying the change to the entire codebase when the new field got introduced, and due to #5350 not catching that oversight in other modules. Also reviewed codebase and discovered that `shortLog` for Deneb execution payloads has same bug.
|
Thanks for the detailed report: https://notes.ethereum.org/ERz33WNETxeO2Bt1CqST2Q?view |
This was referenced Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
blob_gas_usedfield was not properly populated when constructing Deneb light client data. This is due to #5026 not applying the change to the entire codebase when the new field got introduced, and due to #5350 not catching that oversight in other modules. Also reviewed codebase and discovered thatshortLogfor Deneb execution payloads has same bug.