Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

partially revert https://github.com/status-im/nimbus-eth2/pull/5765 #5833

Merged
merged 1 commit into from
Jan 28, 2024

Conversation

tersec
Copy link
Contributor

@tersec tersec commented Jan 28, 2024

Checking regarding a regression in Goerli/Prater

@tersec tersec enabled auto-merge (squash) January 28, 2024 22:18
Copy link

Unit Test Results

         9 files  ±0    1 101 suites  ±0   27m 42s ⏱️ -27s
  4 226 tests ±0    3 879 ✔️ ±0  347 💤 ±0  0 ±0 
16 873 runs  ±0  16 475 ✔️ ±0  398 💤 ±0  0 ±0 

Results for commit c5dd5f0. ± Comparison against base commit 5c54eb5.

@tersec tersec merged commit 225ef5e into unstable Jan 28, 2024
11 checks passed
@tersec tersec deleted the partial-revert-5765 branch January 28, 2024 22:45
@tersec
Copy link
Contributor Author

tersec commented Jan 29, 2024

With this PR:

$ grep "Slot start" nimbus_working.log | jq -r '[.slot, .head]|@tsv'
7499267	020c88f3:7499239
7499268	43d191ae:7499240
7499269	e7b53879:7499268
7499270	e7b53879:7499268
7499271	c4aa370b:7499270
7499272	80cf7b6a:7499271
7499273	e0832f41:7499272
7499274	eea932dd:7499273
7499275	17d64af1:7499274
7499276	c7d77c6a:7499275
7499277	e35a5bc1:7499276
7499278	d522c4b4:7499277
7499279	d522c4b4:7499277
7499280	01c9e52a:7499279
7499281	ccfbd88e:7499280
7499282	fc14d9a5:7499281
7499283	58dcd866:7499282
7499284	e550db7a:7499283
7499285	f90e5acc:7499284
7499286	8446778d:7499285
7499287	aad86f57:7499286
7499288	062032b0:7499287
7499289	457a894f:7499288
7499290	b281d886:7499289
7499291	d347cbb7:7499290
7499292	d347cbb7:7499290
7499293	bd390a83:7499292
7499294	282f53d5:7499293

Without this PR, in v24.1.2:

$ grep "Slot start" nimbus_broken.log | tail -n100 | jq -r '[.slot, .head]|@tsv'
7499165	f17ba8ba:7499162
7499166	5a309297:7499163
7499167	5a309297:7499163
7499168	5a309297:7499163
7499169	5a309297:7499163
7499170	5a309297:7499163
7499171	5a309297:7499163
7499172	5a309297:7499163
7499173	5a309297:7499163
7499174	5a309297:7499163
7499175	5a309297:7499163
7499176	5a309297:7499163
7499177	5a309297:7499163
7499178	5a309297:7499163
7499179	5a309297:7499163
7499180	5a309297:7499163
7499181	5a309297:7499163
7499182	5a309297:7499163
7499183	5a309297:7499163
7499184	5a309297:7499163
7499185	5a309297:7499163
7499186	5a309297:7499163
7499187	5a309297:7499163
7499188	5a309297:7499163
7499189	5a309297:7499163
7499190	5a309297:7499163
7499191	5a309297:7499163
7499192	5a309297:7499163
7499193	5a309297:7499163
7499194	5a309297:7499163
7499195	5a309297:7499163
7499196	5a309297:7499163
7499197	0eb51945:7499180
7499198	0eb51945:7499180
7499199	0eb51945:7499180
7499200	0eb51945:7499180
7499201	0eb51945:7499180
7499202	0eb51945:7499180
7499203	0eb51945:7499180
7499204	0eb51945:7499180
7499205	0eb51945:7499180
7499206	0eb51945:7499180
7499207	0eb51945:7499180
7499208	0eb51945:7499180
7499209	0eb51945:7499180
7499210	0eb51945:7499180
7499211	0eb51945:7499180
7499212	0eb51945:7499180
7499213	0eb51945:7499180
7499214	a71d11b6:7499211
7499215	a71d11b6:7499211
7499216	a71d11b6:7499211
7499217	a71d11b6:7499211
7499218	a71d11b6:7499211
7499219	a71d11b6:7499211
7499220	a71d11b6:7499211
7499221	a71d11b6:7499211
7499222	a71d11b6:7499211
7499223	a71d11b6:7499211
7499224	a71d11b6:7499211
7499225	a71d11b6:7499211
7499226	a71d11b6:7499211
7499227	a71d11b6:7499211
7499228	a71d11b6:7499211
7499229	a71d11b6:7499211
7499230	a71d11b6:7499211
7499231	a71d11b6:7499211
7499232	a71d11b6:7499211
7499233	a71d11b6:7499211
7499234	a71d11b6:7499211
7499235	a71d11b6:7499211
7499236	a71d11b6:7499211
7499237	a71d11b6:7499211
7499238	a71d11b6:7499211
7499239	a71d11b6:7499211
7499240	a71d11b6:7499211
7499241	a71d11b6:7499211
7499242	a71d11b6:7499211
7499243	a71d11b6:7499211
7499244	a71d11b6:7499211
7499245	a71d11b6:7499211
7499246	ccb9c5a0:7499232
7499247	020c88f3:7499239
7499248	020c88f3:7499239
7499249	020c88f3:7499239
7499250	020c88f3:7499239
7499251	020c88f3:7499239
7499252	020c88f3:7499239
7499253	020c88f3:7499239
7499254	020c88f3:7499239
7499255	020c88f3:7499239
7499256	020c88f3:7499239
7499257	020c88f3:7499239
7499258	020c88f3:7499239
7499259	020c88f3:7499239
7499260	020c88f3:7499239
7499261	020c88f3:7499239
7499262	020c88f3:7499239
7499263	020c88f3:7499239
7499264	020c88f3:7499239

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant