Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix checkpoint block potentially not getting backfilled into DB" #5871

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

tersec
Copy link
Contributor

@tersec tersec commented Feb 9, 2024

Reverts #5863

20240209_12h30m28s_grim

Will wait a small amount of time to see if one of the previous commits marks where this begins.

@tersec
Copy link
Contributor Author

tersec commented Feb 9, 2024

Unsupported **size** in type/size combination: array[0,uint8]
Unsupported **size** in type/size combination: array[0,uint128]
Unsupported **size** in type/size combination: array[0,bool]
Unsupported **size** in type/size combination: array[0,uint64]
s.. (0.05s)
Slashing Interchange tests  [Preset: mainnet] ..s...s.....................s......... (0.43s)
Slashing Protection DB [Preset: mainnet] ............ (0.15s)
Validator Client test suite ........... (1.55s)
Block pool processing [Preset: mainnet] ..... (0.54s)
Block pool altair processing [Preset: mainnet] . (0.37s)
chain DAG finalization tests [Preset: mainnet] .... (2.90s)
Old database versions [Preset: mainnet] . (0.06s)
Diverging hardforks .. (0.27s)
Backfill .... (0.89s)
Starting states F (0.10s)
============================
  build/all_tests 'Starting states::Starting state without block'
----------------------------
    tests/test_blockchain_dag.nim(1157, 45): Check failed: dag.getBlockIdAtSlot(dag.tail.slot - 2).isNone

  [FAILED ] (  0.10s) Starting state without block

(0.10s)   Starting states

Latest valid hash [Preset: mainnet] . (1.06s)
Pruning . (4.23s)
State history . (0.21s)
Ancestry . (0.43s)

@tersec
Copy link
Contributor Author

tersec commented Feb 9, 2024

20240209_12h59m15s_grim
one down, one to go

@tersec
Copy link
Contributor Author

tersec commented Feb 9, 2024

20240209_13h47m29s_grim

Reverting.

This is basically the interaction between #5863 and #5869 of which the latter happened to merge to unstable first. Both individually passed CI fine.

@tersec tersec merged commit 1575478 into unstable Feb 9, 2024
8 of 11 checks passed
@tersec tersec deleted the revert-5863-dev/etan/ts-backfill branch February 9, 2024 12:49
etan-status added a commit that referenced this pull request Feb 9, 2024
etan-status added a commit that referenced this pull request Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant