Fix exception after updating check run

.vscode/launch.json

@@ -4,6 +4,16 @@
     // For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
     "version": "0.2.0",
     "configurations": [
+        {
+            "type": "node",
+            "request": "launch",
+            "name": "Debug test",
+            "program": "${workspaceFolder}/node_modules/probot/bin/probot.js",
+            "args": ["receive",
+                     "-e", "check_run",
+                     "-p", "${workspaceFolder}/test/fixtures/check_run.rerequested.json",
+                     "${workspaceFolder}/lib/index.js"]
+        },
         {
             "type": "node",
             "request": "attach",

src/dependency-check-gopkg.ts

@@ -152,7 +152,6 @@ export async function checkGoDependenciesAsync(
     return
   }
 
-  // tslint:disable-next-line:max-line-length
   result.checkedDependencyCount += dependencies.length
 
   for (const dependency of dependencies) {

src/index.ts

@@ -36,9 +36,8 @@ export = (app: Application) => {
     })
 
     try {
-      context.log.info(`checking ${context.payload.repository.html_url}/commits/${
-        checkSuite.head_sha
-      } (check_suite.id #${checkSuite.id})
+      context.log.info(
+        `checking ${context.payload.repository.html_url}/commits/${headSHA} (check_suite.id #${checkSuite.id})
 Pull requests: ${Humanize.oxford(checkSuite.pull_requests.map((pr) => pr.url), 5)}`)
 
       check.status = 'in_progress'
@@ -153,7 +152,7 @@ async function queueCheckAsync(context: Context, checkSuite: Octokit.ChecksCreat
     prepareCheckRunUpdate(check, analysisResult)
 
     if (analysisResult.annotations.length === 0) {
-      await updateRunAsync(context, check)
+      await updateRunAsync(context, check, headSHA)
     } else {
       for (
         let annotationIndex = 0;
@@ -166,7 +165,7 @@ async function queueCheckAsync(context: Context, checkSuite: Octokit.ChecksCreat
             : analysisResult.annotations
 
         check.output.annotations = convertAnnotationResults(annotationsSlice)
-        await updateRunAsync(context, check)
+        await updateRunAsync(context, check, headSHA)
       }
     }
     delete pendingChecks[headSHA]
@@ -256,7 +255,8 @@ ${Humanize.oxford(problemSummary.filter((p) => p !== undefined))} in ${humanized
   }
 }
 
-async function updateRunAsync(context: Context, check: Octokit.ChecksUpdateParams) {
+async function updateRunAsync(context: Context, check: Octokit.ChecksUpdateParams,
+                              headSHA: string) {
   for (let attempts = 3; attempts >= 0; ) {
     try {
       const updateResponse = await context.github.checks.update({
@@ -277,9 +277,9 @@ async function updateRunAsync(context: Context, check: Octokit.ChecksUpdateParam
         status: check.status,
       })
       context.log.info(
-        `HTTP ${updateResponse.status} - Finished updating check run #${check.check_run_id} for ${
-          context.payload.repository.html_url
-        }/commits/${context.payload.check_suite.head_sha}: ${check.status}, ${check.conclusion}`,
+        `HTTP ${updateResponse.status} - Finished updating check run ${
+          context.payload.repository.html_url}/runs/${check.check_run_id} for ${
+          context.payload.repository.html_url}/commits/${headSHA}: ${check.status}, ${check.conclusion}`,
       )
       break
     } catch (error) {

test/fixtures/check_run.rerequested.json

@@ -0,0 +1,240 @@
+{
+  "action": "rerequested",
+  "check_run": {
+    "id": 51524612,
+    "node_id": "MDg6Q2hlY2tSdW41MTUyNDYxMg==",
+    "head_sha": "f07057daec407602858197cc990865765383dcb1",
+    "external_id": "",
+    "url": "https://api.github.com/repos/status-im/status-react/check-runs/51524612",
+    "html_url": "https://github.com/status-im/status-react/runs/51524612",
+    "details_url": "https://github.com/status-im/packages-check-bot/blob/master/README.md",
+    "status": "completed",
+    "conclusion": "failure",
+    "started_at": "2019-01-17T22:32:34Z",
+    "completed_at": "2019-01-17T22:33:05Z",
+    "output": {
+      "title": "package.json check",
+      "summary": "Checked 192 dependencies in `desktop_files/package.json.orig` and `mobile_files/package.json.orig`.\n8 failures, 0 warnings in `react-native-i18n`, `react-native`, `react-native-camera`, and 5 others need your attention!",
+      "text": null,
+      "annotations_count": 8,
+      "annotations_url": "https://api.github.com/repos/status-im/status-react/check-runs/51524612/annotations"
+    },
+    "name": "packages-check-bot",
+    "check_suite": {
+      "id": 50724468,
+      "node_id": "MDEwOkNoZWNrU3VpdGU1MDcyNDQ2OA==",
+      "head_branch": "fix/dependency-audit-v1-yarn",
+      "head_sha": "f07057daec407602858197cc990865765383dcb1",
+      "status": "queued",
+      "conclusion": null,
+      "url": "https://api.github.com/repos/status-im/status-react/check-suites/50724468",
+      "before": "b2eac6e8c32368f8d6acacef9136a31b71a077bf",
+      "after": "f07057daec407602858197cc990865765383dcb1",
+      "pull_requests": [
+
+      ],
+      "app": {
+        "id": 23699,
+        "node_id": "MDM6QXBwMjM2OTk=",
+        "owner": {
+          "login": "PombeirP",
+          "id": 138074,
+          "node_id": "MDQ6VXNlcjEzODA3NA==",
+          "avatar_url": "https://avatars1.githubusercontent.com/u/138074?v=4",
+          "gravatar_id": "",
+          "url": "https://api.github.com/users/PombeirP",
+          "html_url": "https://github.com/PombeirP",
+          "followers_url": "https://api.github.com/users/PombeirP/followers",
+          "following_url": "https://api.github.com/users/PombeirP/following{/other_user}",
+          "gists_url": "https://api.github.com/users/PombeirP/gists{/gist_id}",
+          "starred_url": "https://api.github.com/users/PombeirP/starred{/owner}{/repo}",
+          "subscriptions_url": "https://api.github.com/users/PombeirP/subscriptions",
+          "organizations_url": "https://api.github.com/users/PombeirP/orgs",
+          "repos_url": "https://api.github.com/users/PombeirP/repos",
+          "events_url": "https://api.github.com/users/PombeirP/events{/privacy}",
+          "received_events_url": "https://api.github.com/users/PombeirP/received_events",
+          "type": "User",
+          "site_admin": false
+        },
+        "name": "packages-check-bot",
+        "description": "This Probot checks changes to packages.json to ensure that URL schemes match intended pattern and that forks are referenced with a tag, instead of a branch.",
+        "external_url": "https://github.com/status-im/packages-check-bot/blob/master/README.md",
+        "html_url": "https://github.com/apps/packages-check-bot",
+        "created_at": "2019-01-15T17:02:07Z",
+        "updated_at": "2019-01-16T23:18:31Z"
+      },
+      "created_at": "2019-01-17T22:17:46Z",
+      "updated_at": "2019-01-25T08:47:29Z"
+    },
+    "app": {
+      "id": 23699,
+      "node_id": "MDM6QXBwMjM2OTk=",
+      "owner": {
+        "login": "PombeirP",
+        "id": 138074,
+        "node_id": "MDQ6VXNlcjEzODA3NA==",
+        "avatar_url": "https://avatars1.githubusercontent.com/u/138074?v=4",
+        "gravatar_id": "",
+        "url": "https://api.github.com/users/PombeirP",
+        "html_url": "https://github.com/PombeirP",
+        "followers_url": "https://api.github.com/users/PombeirP/followers",
+        "following_url": "https://api.github.com/users/PombeirP/following{/other_user}",
+        "gists_url": "https://api.github.com/users/PombeirP/gists{/gist_id}",
+        "starred_url": "https://api.github.com/users/PombeirP/starred{/owner}{/repo}",
+        "subscriptions_url": "https://api.github.com/users/PombeirP/subscriptions",
+        "organizations_url": "https://api.github.com/users/PombeirP/orgs",
+        "repos_url": "https://api.github.com/users/PombeirP/repos",
+        "events_url": "https://api.github.com/users/PombeirP/events{/privacy}",
+        "received_events_url": "https://api.github.com/users/PombeirP/received_events",
+        "type": "User",
+        "site_admin": false
+      },
+      "name": "packages-check-bot",
+      "description": "This Probot checks changes to packages.json to ensure that URL schemes match intended pattern and that forks are referenced with a tag, instead of a branch.",
+      "external_url": "https://github.com/status-im/packages-check-bot/blob/master/README.md",
+      "html_url": "https://github.com/apps/packages-check-bot",
+      "created_at": "2019-01-15T17:02:07Z",
+      "updated_at": "2019-01-16T23:18:31Z"
+    },
+    "pull_requests": [
+
+    ]
+  },
+  "repository": {
+    "id": 52308441,
+    "node_id": "MDEwOlJlcG9zaXRvcnk1MjMwODQ0MQ==",
+    "name": "status-react",
+    "full_name": "status-im/status-react",
+    "private": false,
+    "owner": {
+      "login": "status-im",
+      "id": 11767950,
+      "node_id": "MDEyOk9yZ2FuaXphdGlvbjExNzY3OTUw",
+      "avatar_url": "https://avatars1.githubusercontent.com/u/11767950?v=4",
+      "gravatar_id": "",
+      "url": "https://api.github.com/users/status-im",
+      "html_url": "https://github.com/status-im",
+      "followers_url": "https://api.github.com/users/status-im/followers",
+      "following_url": "https://api.github.com/users/status-im/following{/other_user}",
+      "gists_url": "https://api.github.com/users/status-im/gists{/gist_id}",
+      "starred_url": "https://api.github.com/users/status-im/starred{/owner}{/repo}",
+      "subscriptions_url": "https://api.github.com/users/status-im/subscriptions",
+      "organizations_url": "https://api.github.com/users/status-im/orgs",
+      "repos_url": "https://api.github.com/users/status-im/repos",
+      "events_url": "https://api.github.com/users/status-im/events{/privacy}",
+      "received_events_url": "https://api.github.com/users/status-im/received_events",
+      "type": "Organization",
+      "site_admin": false
+    },
+    "html_url": "https://github.com/status-im/status-react",
+    "description": "a free (libre) open source, mobile OS for Ethereum",
+    "fork": false,
+    "url": "https://api.github.com/repos/status-im/status-react",
+    "forks_url": "https://api.github.com/repos/status-im/status-react/forks",
+    "keys_url": "https://api.github.com/repos/status-im/status-react/keys{/key_id}",
+    "collaborators_url": "https://api.github.com/repos/status-im/status-react/collaborators{/collaborator}",
+    "teams_url": "https://api.github.com/repos/status-im/status-react/teams",
+    "hooks_url": "https://api.github.com/repos/status-im/status-react/hooks",
+    "issue_events_url": "https://api.github.com/repos/status-im/status-react/issues/events{/number}",
+    "events_url": "https://api.github.com/repos/status-im/status-react/events",
+    "assignees_url": "https://api.github.com/repos/status-im/status-react/assignees{/user}",
+    "branches_url": "https://api.github.com/repos/status-im/status-react/branches{/branch}",
+    "tags_url": "https://api.github.com/repos/status-im/status-react/tags",
+    "blobs_url": "https://api.github.com/repos/status-im/status-react/git/blobs{/sha}",
+    "git_tags_url": "https://api.github.com/repos/status-im/status-react/git/tags{/sha}",
+    "git_refs_url": "https://api.github.com/repos/status-im/status-react/git/refs{/sha}",
+    "trees_url": "https://api.github.com/repos/status-im/status-react/git/trees{/sha}",
+    "statuses_url": "https://api.github.com/repos/status-im/status-react/statuses/{sha}",
+    "languages_url": "https://api.github.com/repos/status-im/status-react/languages",
+    "stargazers_url": "https://api.github.com/repos/status-im/status-react/stargazers",
+    "contributors_url": "https://api.github.com/repos/status-im/status-react/contributors",
+    "subscribers_url": "https://api.github.com/repos/status-im/status-react/subscribers",
+    "subscription_url": "https://api.github.com/repos/status-im/status-react/subscription",
+    "commits_url": "https://api.github.com/repos/status-im/status-react/commits{/sha}",
+    "git_commits_url": "https://api.github.com/repos/status-im/status-react/git/commits{/sha}",
+    "comments_url": "https://api.github.com/repos/status-im/status-react/comments{/number}",
+    "issue_comment_url": "https://api.github.com/repos/status-im/status-react/issues/comments{/number}",
+    "contents_url": "https://api.github.com/repos/status-im/status-react/contents/{+path}",
+    "compare_url": "https://api.github.com/repos/status-im/status-react/compare/{base}...{head}",
+    "merges_url": "https://api.github.com/repos/status-im/status-react/merges",
+    "archive_url": "https://api.github.com/repos/status-im/status-react/{archive_format}{/ref}",
+    "downloads_url": "https://api.github.com/repos/status-im/status-react/downloads",
+    "issues_url": "https://api.github.com/repos/status-im/status-react/issues{/number}",
+    "pulls_url": "https://api.github.com/repos/status-im/status-react/pulls{/number}",
+    "milestones_url": "https://api.github.com/repos/status-im/status-react/milestones{/number}",
+    "notifications_url": "https://api.github.com/repos/status-im/status-react/notifications{?since,all,participating}",
+    "labels_url": "https://api.github.com/repos/status-im/status-react/labels{/name}",
+    "releases_url": "https://api.github.com/repos/status-im/status-react/releases{/id}",
+    "deployments_url": "https://api.github.com/repos/status-im/status-react/deployments",
+    "created_at": "2016-02-22T21:48:48Z",
+    "updated_at": "2019-01-25T07:56:47Z",
+    "pushed_at": "2019-01-25T08:18:06Z",
+    "git_url": "git://github.com/status-im/status-react.git",
+    "ssh_url": "[email protected]:status-im/status-react.git",
+    "clone_url": "https://github.com/status-im/status-react.git",
+    "svn_url": "https://github.com/status-im/status-react",
+    "homepage": "https://status.im",
+    "size": 71842,
+    "stargazers_count": 2542,
+    "watchers_count": 2542,
+    "language": "JavaScript",
+    "has_issues": true,
+    "has_projects": true,
+    "has_downloads": true,
+    "has_wiki": true,
+    "has_pages": false,
+    "forks_count": 627,
+    "mirror_url": null,
+    "archived": false,
+    "open_issues_count": 488,
+    "license": {
+      "key": "mpl-2.0",
+      "name": "Mozilla Public License 2.0",
+      "spdx_id": "MPL-2.0",
+      "url": "https://api.github.com/licenses/mpl-2.0",
+      "node_id": "MDc6TGljZW5zZTE0"
+    },
+    "forks": 627,
+    "open_issues": 488,
+    "watchers": 2542,
+    "default_branch": "develop"
+  },
+  "organization": {
+    "login": "status-im",
+    "id": 11767950,
+    "node_id": "MDEyOk9yZ2FuaXphdGlvbjExNzY3OTUw",
+    "url": "https://api.github.com/orgs/status-im",
+    "repos_url": "https://api.github.com/orgs/status-im/repos",
+    "events_url": "https://api.github.com/orgs/status-im/events",
+    "hooks_url": "https://api.github.com/orgs/status-im/hooks",
+    "issues_url": "https://api.github.com/orgs/status-im/issues",
+    "members_url": "https://api.github.com/orgs/status-im/members{/member}",
+    "public_members_url": "https://api.github.com/orgs/status-im/public_members{/member}",
+    "avatar_url": "https://avatars1.githubusercontent.com/u/11767950?v=4",
+    "description": "A Mobile Ethereum Client."
+  },
+  "sender": {
+    "login": "PombeirP",
+    "id": 138074,
+    "node_id": "MDQ6VXNlcjEzODA3NA==",
+    "avatar_url": "https://avatars1.githubusercontent.com/u/138074?v=4",
+    "gravatar_id": "",
+    "url": "https://api.github.com/users/PombeirP",
+    "html_url": "https://github.com/PombeirP",
+    "followers_url": "https://api.github.com/users/PombeirP/followers",
+    "following_url": "https://api.github.com/users/PombeirP/following{/other_user}",
+    "gists_url": "https://api.github.com/users/PombeirP/gists{/gist_id}",
+    "starred_url": "https://api.github.com/users/PombeirP/starred{/owner}{/repo}",
+    "subscriptions_url": "https://api.github.com/users/PombeirP/subscriptions",
+    "organizations_url": "https://api.github.com/users/PombeirP/orgs",
+    "repos_url": "https://api.github.com/users/PombeirP/repos",
+    "events_url": "https://api.github.com/users/PombeirP/events{/privacy}",
+    "received_events_url": "https://api.github.com/users/PombeirP/received_events",
+    "type": "User",
+    "site_admin": false
+  },
+  "installation": {
+    "id": 594560,
+    "node_id": "MDIzOkludGVncmF0aW9uSW5zdGFsbGF0aW9uNTk0NTYw"
+  }
+}