-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Community permissions] Modify JoinCommunity API to accept which addresses the user wants to share with the Owner #11154
Comments
jrainville
added a commit
that referenced
this issue
Jun 22, 2023
jrainville
added a commit
that referenced
this issue
Jun 22, 2023
jrainville
added a commit
that referenced
this issue
Jun 22, 2023
jrainville
added a commit
that referenced
this issue
Jun 26, 2023
jrainville
added a commit
that referenced
this issue
Jun 27, 2023
jrainville
added a commit
that referenced
this issue
Jun 28, 2023
jrainville
added a commit
that referenced
this issue
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
WIP Design: https://www.figma.com/file/uHwhhUsne96HBhkunsD7Po/WIP-flows?type=design&node-id=8-34089&t=rwfZUnY460xDJdUi-0
Currently, when joining a community, if it doesn't have any permission, we share all of the user's Wallet addresses with the Owner node. If it does have permissions, we share the addresses that fulfill the permissions.
What we now want is to give the user the option to choose which address they want to share.
There is also the choice to just share all addresses, in that case, it uses the same method we have right now.
The new API will pass a list of addresses to the backend, and then to the owner.
One caveat, if the list of addresses does not fulfill the permissions to join, we need to reject the call before sending to the Owner. That means returning an error.
If it does fulfill the permission to join, or if there is no permission to join, then the call is valid and is sent to the Owner and the flow stays the same as before.
Also, if the community has Admin permissions, they do not have to be fulfilled for the call to be valid. For example, if a community requires 10 SNT to join and 1 special collectible to be admin, if the user only has 10 SNT in the shared addresses, that is valid.
Most of the code should be already there, we just need to modify or add a new API endpoint in status-go so that we don't just pass the password, we also pass the list of addresses the user wants to share.
There is no UI work to be done with this task. Mostly status-go, but also a little bit of Nim to modify the functions that will be called from QML. Feel free to use a placeholder UI to test, but status-go tests can suffice.
Acceptance Criteria
The text was updated successfully, but these errors were encountered: