Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dApps - Can't sign a message from Uniswap #15946

Closed
anastasiyaig opened this issue Aug 1, 2024 · 2 comments
Closed

dApps - Can't sign a message from Uniswap #15946

anastasiyaig opened this issue Aug 1, 2024 · 2 comments
Assignees
Labels
Milestone

Comments

@anastasiyaig
Copy link
Contributor

Bug Report

Description

Signing message from uniswap gets me to rejected state

Steps to reproduce

Screen.Recording.2024-08-01.at.07.13.47.mov

Actual behavior

ERR 2024-08-01 07:14:49.835+03:00 rpc response error                         topics="rpc" tid=27431383 file=core.nim:36 err="\nstatus-go error [methodName:wallet_safeSignTypedDataForDApps, code:-32000, message:unknown type \"uint160\" ]\n"
ERR 2024-08-01 07:14:49.835+03:00 error doing rpc request                    topics="rpc" tid=27431383 file=core.nim:39 methodName=wallet_safeSignTypedDataForDApps exception="\nstatus-go error [methodName:wallet_safeSignTypedDataForDApps, code:-32000, message:unknown type \"uint160\" ]\n"
DBG 2024-08-01 07:14:49.835+03:00 qt message 

Additional Information

  • Status desktop version: 2.30 RC4
  • Operating System: MacOS
@clauxx
Copy link
Member

clauxx commented Aug 1, 2024

Seems like this issue is caused by the old version of geth on status-go, which doesn't include all solidity types for typed data, which are supposed to be included based on EIP-712. Hence, requests that include e.g. uint160, uint48, etc. in the types are considered invalid for now. The issue seems fixed on go-ethereum master, where they support all types necessary.

Can be moved to 2.31 for now, as we definitely cannot fix it in 2.30.

@alexjba
Copy link
Contributor

alexjba commented Sep 5, 2024

Closed by status-im/status-go#5755

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

When branches are created from issues, their pull requests are automatically linked.

5 participants