-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump(go-ethereum): Bump go-ethereum version to include sign fix #5755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (5)
|
alexjba
force-pushed
the
chore/cherry-pick-solidity-primitive-fix
branch
from
August 21, 2024 05:29
de165f4
to
04b9329
Compare
alexjba
added a commit
to status-im/status-desktop
that referenced
this pull request
Aug 21, 2024
There are two fixes needed here. 1. Status-go fix for unknown primitive when signing the message 2. Fix for Paraswap pairing failure due to required namespaces mismatch Needs: status-im/status-go#5755
alexjba
added a commit
to status-im/status-desktop
that referenced
this pull request
Aug 21, 2024
There are two fixes needed here. 1. Status-go fix for unknown primitive when signing the message 2. Fix for Paraswap pairing failure due to required namespaces mismatch Needs: status-im/status-go#5755
4 tasks
Accept all primitive types in Solidity for EIP-712 from intN, uintN, intN[], uintN[] for N as 0 to 256 in multiples of 8 --------- Co-authored-by: Martin Holst Swende <[email protected]> (cherry picked from commit 02796f6bee7e014fd16ad39f0bcd3b665b51e0bb)
alexjba
force-pushed
the
chore/cherry-pick-solidity-primitive-fix
branch
from
August 21, 2024 06:42
04b9329
to
ac3f966
Compare
clauxx
approved these changes
Aug 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this! Should fix the issues we have with some dapps when signing typed data!
saledjenic
approved these changes
Aug 21, 2024
alexjba
added a commit
to status-im/status-desktop
that referenced
this pull request
Aug 22, 2024
There are two fixes needed here. 1. Status-go fix for unknown primitive when signing the message 2. Fix for Paraswap pairing failure due to required namespaces mismatch Needs: status-im/status-go#5755
alexjba
added a commit
to status-im/status-desktop
that referenced
this pull request
Aug 26, 2024
There are two fixes needed here. 1. Status-go fix for unknown primitive when signing the message 2. Fix for Paraswap pairing failure due to required namespaces mismatch Needs: status-im/status-go#5755
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picking ethereum/go-ethereum#26770
Accept all primitive types in Solidity for EIP-712 from intN, uintN, intN[], uintN[] for N as 0 to 256 in multiples of 8
Co-authored-by: Martin Holst Swende [email protected]
(cherry picked from commit 02796f6bee7e014fd16ad39f0bcd3b665b51e0bb)
Important changes:
Fixing status-im/status-desktop#15946