Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for synchronized & backed up settings #10865

Merged
merged 4 commits into from
May 31, 2023
Merged

Conversation

saledjenic
Copy link
Contributor

@saledjenic saledjenic commented May 30, 2023

This PR handles items from the settings table on the desktop app side and this way aligns mobile and desktop app.

There are items which are marked as inactive on the status-go side and because of that they are excluded from syncing and backing up.

There is a table in the description of #10389 describing the state of handling synced&backed up settings' items.

The work is splitted in several commits that can be easier for review. Single commit handles single setting.

Fixes: #10389

@saledjenic saledjenic requested review from alaibe, stefandunca, Khushboo-dev-cpp and a team May 30, 2023 17:23
@status-im-auto
Copy link
Member

status-im-auto commented May 30, 2023

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 2674125 #1 2023-05-30 17:28:32 ~4 min tests/imports 📄log
✔️ 2674125 #1 2023-05-30 17:29:38 ~5 min tests/nim 📄log
2674125 #1 2023-05-30 17:30:57 ~7 min macos/aarch64 📄log
2674125 #1 2023-05-30 17:31:32 ~7 min macos/x86_64 📄log
✔️ 2674125 #1 2023-05-30 17:39:28 ~15 min linux/x86_64 📦tgz
✖️ 2674125 #1 2023-05-30 17:54:29 ~30 min tests/e2e 📄log
✔️ 2674125 #1 2023-05-30 17:59:31 ~35 min windows/x86_64 💿exe
7d5b2a9 #2 2023-05-31 06:35:07 ~3 min macos/aarch64 📄log
✔️ 7d5b2a9 #2 2023-05-31 06:36:51 ~4 min tests/imports 📄log
7d5b2a9 #2 2023-05-31 06:38:00 ~6 min macos/x86_64 📄log
✔️ 7d5b2a9 #2 2023-05-31 06:38:18 ~6 min tests/nim 📄log
✔️ 7d5b2a9 #2 2023-05-31 06:45:19 ~13 min linux/x86_64 📦tgz
✔️ 7d5b2a9 #2 2023-05-31 07:05:08 ~33 min windows/x86_64 💿exe
✔️ 7d5b2a9 #2 2023-05-31 07:08:27 ~36 min tests/e2e 📄log

@saledjenic saledjenic merged commit ffc0593 into master May 31, 2023
@saledjenic saledjenic deleted the fix/issue-10389 branch May 31, 2023 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for synchronized & backed up settings
4 participants