feat: Simple send modal recipient view #17096
Open
+2,725
−237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cuteivist
requested review from
caybro,
micieslak,
alexjba and
Khushboo-dev-cpp
Cuteivist
force-pushed
the
feat/recipient-selector-19916
branch
from
ec9deff to
27dcfd2
Compare
Jenkins BuildsClick to see older builds (7)
|
caybro
reviewed
Jan 21, 2025
| if (sensor.containsMouse) { | ||
| return root.address | ||
| } | ||
| return elideAddress ? StatusQUtils.Utils.elideText(root.address, 6, 4) : root.address |
There was a problem hiding this comment.
We have some dedicated "elide wallet address" function imo
There was a problem hiding this comment.
I used this one, because the dedicated one uses specific character to display "x", which doesn't display correctly on indenticon.
Added comment here
Cuteivist
force-pushed
the
feat/recipient-selector-19916
branch
2 times, most recently
from
13a260f to
8dd3ea0
Compare
Cuteivist
force-pushed
the
feat/recipient-selector-19916
branch
from
8dd3ea0 to
6158b50
Compare
|
@caybro updated all your remarks. Thanks for improvement ideas! Please have a look again. |
caybro
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16916
User stories (during the update): https://www.notion.so/Recipient-selection-12e8f96fb65c80cebb0deb75533fa255
What does the PR do
Affected areas
Architecture compliance
My PR is consistent with this document: Status Desktop Architecture Guide
Screenshot of functionality (including design for comparison)
recipient_view.mov