Fix some issues with pinned messages

There were a couple of issues on how we handle pinned messages: 1) Clock of the message was only checked when saving, meaning that the client would receive potentially updates that were not to be processed. 2) We relied on the client to generate a notification for a pinned message by sending a normal message through the wire. This PR changes the behavior so that the notification is generated locally, either on response to a network event or client event. 3) When deleting a message, we pull all the replies/pinned notifications and send them over to the client so they know that those messages needs updating.
status-im · Apr 19, 2023 · 2b29f40 · 2b29f40
1 parent a596bcb
commit 2b29f40
Show file tree

Hide file tree

Showing 28 changed files with 791 additions and 514 deletions.
diff --git a/appdatabase/migrations/bindata.go b/appdatabase/migrations/bindata.go
diff --git a/appdatabase/migrations/sql/1681934966_add_index_response_to.up.sql b/appdatabase/migrations/sql/1681934966_add_index_response_to.up.sql
@@ -0,0 +1 @@
+CREATE INDEX user_messages_response_to ON user_messages(response_to);
diff --git a/appdatabase/migrationsprevnodecfg/bindata.go b/appdatabase/migrationsprevnodecfg/bindata.go
diff --git a/go.mod b/go.mod
@@ -78,8 +78,8 @@ require (
 	github.com/ipfs/go-log/v2 v2.5.1
 	github.com/ladydascalie/currency v1.6.0
 	github.com/meirf/gopart v0.0.0-20180520194036-37e9492a85a8
-	github.com/waku-org/go-waku v0.5.3-0.20230404182041-41691a44e579
 	github.com/schollz/peerdiscovery v1.7.0
+	github.com/waku-org/go-waku v0.5.3-0.20230404182041-41691a44e579
 	github.com/yeqown/go-qrcode/v2 v2.2.1
 	github.com/yeqown/go-qrcode/writer/standard v1.2.1
 	go.uber.org/multierr v1.8.0

diff --git a/mailserver/migrations/bindata.go b/mailserver/migrations/bindata.go
diff --git a/multiaccounts/migrations/bindata.go b/multiaccounts/migrations/bindata.go
diff --git a/protocol/anonmetrics/migrations/migrations.go b/protocol/anonmetrics/migrations/migrations.go
diff --git a/protocol/common/pin_message.go b/protocol/common/pin_message.go
@@ -31,6 +31,8 @@ type PinMessage struct {
 	Identicon string `json:"identicon"`
 	// Random 3 words name
 	Alias string `json:"alias"`
+
+	Message *PinnedMessage `json:"pinnedMessage"`
 }
 
 type PinnedMessage struct {
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		CREATE INDEX user_messages_response_to ON user_messages(response_to);