Skip to content

Commit

Permalink
Added a TODO for improving validation of multiple images
Browse files Browse the repository at this point in the history
We don't want a complete fail if only a single image fails.
  • Loading branch information
Samyoul committed Mar 1, 2021
1 parent 1789a94 commit bb9f1c2
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions protocol/persistence.go
Original file line number Diff line number Diff line change
Expand Up @@ -549,6 +549,7 @@ func (db sqlitePersistence) SaveContactChatIdentity(contactID string, chatIdenti
continue
}

// TODO implement something that doesn't reject all images if a single image fails validation
// Validate image URI to make sure it's serializable
_, err = images.GetPayloadDataURI(image.Payload)
if err != nil {
Expand Down

0 comments on commit bb9f1c2

Please sign in to comment.