Simplify Post() implementation in sshext

[adambabik]

Problem

ethereum/go-ethereum#16495 got merged recently and shh_post returns a hash of the envelope instead of boolean now.

Implementation

Two possible solutions.

Remove shhext_post

Remove shhext_post and patch the original shh_post with a tracker. This may require patching web3.js as well.

Simplify shhext_post

Keep shhext_post but simplify its implementation to call shh_post internally. The implementation will just keep the tracker.

Acceptance Criteria

• messaging works as expected,
• all existing tests related to shhext_post pass.

Notes

Blocked until Geth 1.8.5 is released.

[dshulyak]

shh_post should be patched now instead of using our namespace (shhext) for post

[adambabik]

What will be changed in the patch? Just addition of events?

[dshulyak]

Also tracker will have to be added to original shh_post.

…

On Mon, Apr 23, 2018, 13:21 Adam Babik ***@***.***> wrote: What will be changed in the patch? Just addition of events? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#853 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AB36IFeuvxT5m347OyYTWOfLgPGizs0qks5trasQgaJpZM4Te7zr> .

[dshulyak]

Keep shhext_post but simplify its implementation to call shh_post internally. The implementation will just keep the tracker.

didn't notice this part initially.
you are right that we can keep shhext_post instead of adding tracker to shh_post.

[dshulyak]

Unblocking as 1.8.5 got released this morning 😄