http server for images #2418
Merged
http server for images #2418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Checklist
|
Jenkins BuildsClick to see older builds (63)
|
| s.logger.Error("could not generate identicon") | ||
| } | ||
|
|
||
| w.Header().Set("Content-Type", "image/png") |
There was a problem hiding this comment.
Would it make sense to add headers like these so the browser keeps the identicons in cache?:
w.Header().Set("Cache-Control", "max-age:290304000, public")
w.Header().Set("Expires", time.Now().AddDate(60, 0, 0).Format(http.TimeFormat))| pk := pks[0] | ||
| image, err := identicon.Generate(pk) | ||
| if err != nil { | ||
| s.logger.Error("could not generate identicon") |
There was a problem hiding this comment.
Could be interesting to add a default image placeholder here for cases where the identicon could not be generated
protocol/images/server.go
Outdated
| } | ||
|
|
||
| func (s *Server) Start() error { | ||
| listener, err := net.Listen("tcp", ":0") |
There was a problem hiding this comment.
Suggested change
| listener, err := net.Listen("tcp", ":0") | |
| listener, err := net.Listen("tcp", "localhost:0") |
0kok0
reviewed
Nov 4, 2021
protocol/images/server.go
Outdated
| } | ||
|
|
||
| func (s *Server) Start() error { | ||
| listener, err := net.Listen("tcp", ":0") |
There was a problem hiding this comment.
Would it also be possible to use net.http.ListenAndServeTLS instead or a tls.listener? TLS with self signed certs would harden the architecture here, also it wouldn't be a problem if at some point in time the server is moved out of the local application.
There was a problem hiding this comment.
Thanks for the review, sorry for the late reply, I missed the comment.
I'll look into it, we can definitely use a self signed certificate in the go code, but the tricky bit is to have the client accept a self signed certificate, I'll have a look.
So far I was looking at https://developer.apple.com/documentation/foundation/url_loading_system/handling_an_authentication_challenge/performing_manual_server_trust_authentication for IOS, but I'll have to spend a bit more time researching.
cammellos
force-pushed
the
experiment/run-http-image-server-2
branch
from
6cd1cbd to
b8435b4
Compare
cammellos
reviewed
Feb 4, 2022
protocol/images/server.go
Outdated
|
|
||
| derBytes, err := x509.CreateCertificate(rand.Reader, &template, &template, &priv.PublicKey, priv) | ||
| if err != nil { | ||
| log.Fatalf("Failed to create certificate: %v", err) |
There was a problem hiding this comment.
Do you not want to return in this case? similarly below, maybe we should just make the FN return an error and abort if we cant' create?
There was a problem hiding this comment.
right, I forgot about that, sorry. I don't expect errors to ever happen since there is no user input among the parameters, but better safe than sorry. Fixed now.
|
TODO: (reminder to self) bump the VERSION file right before mering |
cammellos
approved these changes
Feb 4, 2022
bitgamma
force-pushed
the
experiment/run-http-image-server-2
branch
from
5de0be7 to
5cd8b63
Compare
bitgamma
force-pushed
the
experiment/run-http-image-server-2
branch
from
c65fa14 to
fddab92
Compare
bitgamma
force-pushed
the
experiment/run-http-image-server-2
branch
from
55b0cf8 to
2bb4b3b
Compare
bitgamma
force-pushed
the
experiment/run-http-image-server-2
branch
from
e63bfba to
f9cf690
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[EXPERIMENT] http server for images