You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before syncing, topics are sorted by priority. In case if all topics have zero priority requests are executed as before. Otherwise, topics with higher priority are requested in first N batches (currently three batches with 1, 5, 10 topics. That's arbitrary, emphasis is on the first batch), and the rest of topics are requested as before.
chat.ReadMessagesAtClockValue is used to prioritise topics before historical requests as it is always updated when the user opens chat (at least in mobile version). We can add a separate field for this but I'm not sure this is necessary.
Hey @rasom -> we are not sure but we are getting a crash after these changes, can you have a look DBG 2022-02-02 13:04:57.626+01:00 NewBE_callPrivateRPC topics="rpc" tid=18836562 file=core.nim:24 rpc_method=wakuext_importCommunity
panic: runtime error: index out of range [0] with length 0
goroutine 4351 [running]:
github.com/status-im/status-go/protocol.(*Messenger).syncFilters(0xc00092ce00, 0x0, 0x0, 0x0, 0x0, 0x5d011a27e8d936b7, 0xabc701512a75b559)
/Users/sale/Status/desktop-app/vendor/status-lib/vendor/status-go/protocol/messenger_mailserver.go:291 +0x1fac
github.com/status-im/status-go/protocol.(*Messenger).scheduleSyncFilters.func1(0xc00092ce00, 0x0, 0x0, 0x0)
/Users/sale/Status/desktop-app/vendor/status-lib/vendor/status-go/protocol/messenger_mailserver.go:103 +0x6a
created by github.com/status-im/status-go/protocol.(*Messenger).scheduleSyncFilters
/Users/sale/Status/desktop-app/vendor/status-lib/vendor/status-go/protocol/messenger_mailserver.go:102 +0x29f
nim_status_client(63447,0x70000edbe000) malloc: *** error for object 0x7f99434df820: pointer being freed was not allocated
nim_status_client(63447,0x70000edbe000) malloc: *** set a breakpoint in malloc_error_break to debug
^Cmake: *** [run-macos] Killed: 9
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rasom
force-pushed
the
feat/#12783-chat-topics-retreiving-order
branch
from
needed for status-im/status-mobile#12783
Before syncing, topics are sorted by priority. In case if all topics have zero priority requests are executed as before. Otherwise, topics with higher priority are requested in first N batches (currently three batches with 1, 5, 10 topics. That's arbitrary, emphasis is on the first batch), and the rest of topics are requested as before.
chat.ReadMessagesAtClockValueis used to prioritise topics before historical requests as it is always updated when the user opens chat (at least in mobile version). We can add a separate field for this but I'm not sure this is necessary.status: ready