Use Nix shell in the Makefile for builds #4388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @apentori, and thank you so much for making your first pull request in status-go! ❤️ Please help us make your experience better by filling out this brief questionnaire https://goo.gl/forms/uWqNcVpVz7OIopXg2 |
Jenkins BuildsClick to see older builds (123)
|
|
I would't attempt to remove generated files in this PR. First I would try to get this to work in CI as-is. |
jakubgs
reviewed
Nov 28, 2023
jakubgs
reviewed
Nov 28, 2023
jakubgs
reviewed
Nov 28, 2023
jakubgs
reviewed
Nov 28, 2023
jakubgs
reviewed
Nov 28, 2023
apentori
force-pushed
the
using-nix-shell-in-makefile
branch
from
8cb60b5 to
f747e83
Compare
Merged
apentori
commented
Feb 20, 2024
jakubgs
reviewed
Feb 20, 2024
jakubgs
reviewed
Feb 20, 2024
jakubgs
reviewed
Feb 20, 2024
jakubgs
reviewed
Feb 20, 2024
jakubgs
reviewed
Feb 20, 2024
jakubgs
reviewed
Feb 20, 2024
jakubgs
reviewed
Feb 20, 2024
apentori
force-pushed
the
using-nix-shell-in-makefile
branch
from
06b0eca to
a49bb24
Compare
|
Building with make seems to work make statusgo
Missing TARGET, assuming default target. See nix/README.md for more details.
Configuring Nix shell for target 'default'...
Missing TARGET, assuming default target. See nix/README.md for more details.
Configuring Nix shell for target 'default'...
Missing TARGET, assuming default target. See nix/README.md for more details.
Configuring Nix shell for target 'default'...
go build -mod=vendor -v \
-tags 'gowaku_no_rln' -ldflags=' -X github.com/status-im/status-go/params.Version=0.175.1 -X github.com/status-im/status-go/params.GitCommit=cda4aca61 -X github.com/status-im/status-go/params.IpfsGatewayURL=https://ipfs.status.im/ -X github.com/status-im/status-go/vendor/github.com/ethereum/go-ethereum/metrics.EnabledStr=true' \
-o ./build/bin/statusd ./cmd/statusd
Missing TARGET, assuming default target. See nix/README.md for more details.
Configuring Nix shell for target 'default'...
google.golang.org/protobuf/internal/flags
google.golang.org/protobuf/internal/set
[...]
github.com/status-im/status-go/cmd/statusd
Missing TARGET, assuming default target. See nix/README.md for more details.
Configuring Nix shell for target 'default'...
Compilation done.
Missing TARGET, assuming default target. See nix/README.md for more details.
Configuring Nix shell for target 'default'...
Run "build/bin/statusd -h" to view available commands.
|
|
@apentori because in a Lines 132 to 137 in cda4aca In this case there's 3 lines, go build and two echo lines. Since they are not joined together with a && \ or ; \ they are separate commands that spawn separate shells.
This is one of the main reasons why people use the |
jakubgs
reviewed
Feb 22, 2024
|
jakubgs
reviewed
Feb 23, 2024
I personally disagree with this, but won't complain as I am going to use Nix 😄 As fro the "full control over build tools and dependencies": Again, I'm just posting my thoughts here. It's not a blocker or requirement from me. |
As I mentioned:
|
|
Why do you use a custom |
I don't do this explicitly myself. This is done my IDE (JetBrains GoLand). Settings |
|
That's fine, just trying to understand the behavior. |
yakimant
reviewed
Mar 27, 2024
yakimant
reviewed
Mar 27, 2024
yakimant
approved these changes
Mar 27, 2024
|
Hmm perhaps with newer I guess for this PR we could stick with older |
|
I think we should use the same commit as |
apentori
force-pushed
the
using-nix-shell-in-makefile
branch
from
b60d425 to
9dc8c79
Compare
siddarthkay
approved these changes
Apr 3, 2024
There was a problem hiding this comment.
Looks good to me and works well locally as well.
@apentori : when you get a chance do push the modified go.mod
Once this is merged It will make my life easier for the upcoming go upgrade.
Thank you!
apentori
force-pushed
the
using-nix-shell-in-makefile
branch
3 times, most recently
from
5e9f3b3 to
77db6c1
Compare
Signed-off-by: Alexis Pentori <[email protected]>
jakubgs
force-pushed
the
using-nix-shell-in-makefile
branch
from
671b07d to
f9df853
Compare
jakubgs
added a commit
to status-im/status-desktop
that referenced
this pull request
Apr 11, 2024
Otherwise it fails with: ``` performing a single-user installation of Nix... directory /nix does not exist; creating it by running 'mkdir -m 0755 /nix && chown jenkins /nix' using sudo sudo: a terminal is required to read the password; either use the -S option to read from standard input or configure an askpass helper /tmp/nix-binary-tarball-unpack.roliyEDk9X/unpack/nix-2.19.3-x86_64-linux/install: please manually run 'mkdir -m 0755 /nix && chown jenkins /nix' as root to create /nix ``` Related to: status-im/status-go#4388 Signed-off-by: Jakub Sokołowski <[email protected]>
apentori
pushed a commit
to status-im/status-desktop
that referenced
this pull request
Apr 11, 2024
Otherwise it fails with: ``` performing a single-user installation of Nix... directory /nix does not exist; creating it by running 'mkdir -m 0755 /nix && chown jenkins /nix' using sudo sudo: a terminal is required to read the password; either use the -S option to read from standard input or configure an askpass helper /tmp/nix-binary-tarball-unpack.roliyEDk9X/unpack/nix-2.19.3-x86_64-linux/install: please manually run 'mkdir -m 0755 /nix && chown jenkins /nix' as root to create /nix ``` Related to: status-im/status-go#4388 Signed-off-by: Jakub Sokołowski <[email protected]> Signed-off-by: Alexis Pentori <[email protected]>
jakubgs
added a commit
to status-im/status-desktop
that referenced
this pull request
Apr 11, 2024
Otherwise it fails with: ``` performing a single-user installation of Nix... directory /nix does not exist; creating it by running 'mkdir -m 0755 /nix && chown jenkins /nix' using sudo sudo: a terminal is required to read the password; either use the -S option to read from standard input or configure an askpass helper /tmp/nix-binary-tarball-unpack.roliyEDk9X/unpack/nix-2.19.3-x86_64-linux/install: please manually run 'mkdir -m 0755 /nix && chown jenkins /nix' as root to create /nix ``` Related to: status-im/status-go#4388 Signed-off-by: Alexis Pentori <[email protected]> Signed-off-by: Jakub Sokołowski <[email protected]>
jakubgs
added a commit
to status-im/status-desktop
that referenced
this pull request
Apr 11, 2024
Otherwise it fails with: ``` performing a single-user installation of Nix... directory /nix does not exist; creating it by running 'mkdir -m 0755 /nix && chown jenkins /nix' using sudo sudo: a terminal is required to read the password; either use the -S option to read from standard input or configure an askpass helper /tmp/nix-binary-tarball-unpack.roliyEDk9X/unpack/nix-2.19.3-x86_64-linux/install: please manually run 'mkdir -m 0755 /nix && chown jenkins /nix' as root to create /nix ``` Related to: status-im/status-go#4388 Signed-off-by: Alexis Pentori <[email protected]> Signed-off-by: Jakub Sokołowski <[email protected]>
jakubgs
added a commit
to status-im/status-desktop
that referenced
this pull request
Apr 11, 2024
Otherwise it fails with: ``` performing a single-user installation of Nix... directory /nix does not exist; creating it by running 'mkdir -m 0755 /nix && chown jenkins /nix' using sudo sudo: a terminal is required to read the password; either use the -S option to read from standard input or configure an askpass helper /tmp/nix-binary-tarball-unpack.roliyEDk9X/unpack/nix-2.19.3-x86_64-linux/install: please manually run 'mkdir -m 0755 /nix && chown jenkins /nix' as root to create /nix ``` Related to: status-im/status-go#4388 Signed-off-by: Alexis Pentori <[email protected]> Signed-off-by: Jakub Sokołowski <[email protected]>
|
For future reference we had to apply some extra fixes for this:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use nix in Makefile and remove generated files from source control
Linked to :
Steps