Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/local telem grafana #6122

Draft
wants to merge 8 commits into
base: develop
Choose a base branch
from
Draft

Conversation

adklempner
Copy link
Contributor

A short summary which serves as a squashed-commit message.

A description to understand introduced changes without reading the code.

Important changes:

  • Something worth noting for reviewers.

Closes #

Copy link

github-actions bot commented Nov 25, 2024

We require commits to follow the Conventional Commits, but with _ for non-breaking changes.
Please fix these commit messages:

clean up metrics
start prometheus metrics when calling initialize application
move all telemetry to prometheus
add prometheus metric for peer count by origin
move metric processing to server
test commit

@adklempner adklempner force-pushed the feat/local-telem-grafana branch from d1599bb to fcc6c19 Compare November 25, 2024 22:03
@status-im-auto
Copy link
Member

status-im-auto commented Nov 25, 2024

Jenkins Builds

Click to see older builds (82)
Commit #️⃣ Finished (UTC) Duration Platform Result
d1599bb #1 2024-11-25 22:03:51 ~52 sec android 📄log
d1599bb #1 2024-11-25 22:03:59 ~51 sec windows 📄log
d1599bb #1 2024-11-25 22:04:08 ~1 min ios 📄log
d1599bb #1 2024-11-25 22:04:16 ~1 min macos 📄log
✖️ d1599bb #1 2024-11-25 22:04:17 ~1 min tests-rpc 📄log
d1599bb #1 2024-11-25 22:04:22 ~1 min linux 📄log
✖️ d1599bb #1 2024-11-25 22:04:53 ~1 min tests 📄log
d1599bb #1 2024-11-25 22:05:15 ~2 min macos 📄log
fcc6c19 #2 2024-11-25 22:04:37 ~33 sec windows 📄log
fcc6c19 #2 2024-11-25 22:04:48 ~54 sec android 📄log
fcc6c19 #2 2024-11-25 22:05:23 ~1 min ios 📄log
c59e6a4 #3 2024-11-25 22:06:29 ~1 min macos 📄log
c59e6a4 #2 2024-11-25 22:06:52 ~2 min linux 📄log
c59e6a4 #3 2024-11-25 22:07:07 ~1 min ios 📄log
✖️ c59e6a4 #2 2024-11-25 22:07:16 ~2 min tests 📄log
✖️ c59e6a4 #2 2024-11-25 22:07:26 ~3 min tests-rpc 📄log
c59e6a4 #3 2024-11-25 22:07:32 ~2 min android 📄log
c59e6a4 #3 2024-11-25 22:08:12 ~3 min windows 📄log
c59e6a4 #3 2024-11-25 22:09:23 ~2 min linux 📄log
c59e6a4 #2 2024-11-25 22:10:15 ~4 min macos 📄log
✖️ af88f60 #3 2024-11-25 22:09:57 ~2 min tests 📄log
✔️ af88f60 #4 2024-11-25 22:11:28 ~3 min macos 📦zip
✔️ af88f60 #4 2024-11-25 22:12:02 ~4 min ios 📦zip
✔️ af88f60 #4 2024-11-25 22:12:15 ~3 min windows 📦zip
✔️ af88f60 #3 2024-11-25 22:12:17 ~4 min tests-rpc 📄log
✔️ af88f60 #4 2024-11-25 22:14:05 ~6 min android 📦aar
✔️ af88f60 #4 2024-11-25 22:14:20 ~4 min linux 📦zip
✔️ af88f60 #4 2024-11-25 22:15:00 ~2 min tests-rpc 📄log
✔️ af88f60 #3 2024-11-25 22:18:19 ~7 min macos 📦zip
✖️ ec960f0 #4 2024-11-27 01:20:12 ~1 min tests 📄log
✔️ ec960f0 #5 2024-11-27 01:22:28 ~4 min windows 📦zip
✔️ ec960f0 #5 2024-11-27 01:22:52 ~4 min ios 📦zip
✔️ ec960f0 #5 2024-11-27 01:23:16 ~4 min macos 📦zip
✔️ ec960f0 #5 2024-11-27 01:23:17 ~4 min tests-rpc 📄log
✔️ ec960f0 #5 2024-11-27 01:24:18 ~6 min linux 📦zip
✔️ ec960f0 #5 2024-11-27 01:24:49 ~6 min android 📦aar
✔️ ec960f0 #4 2024-11-27 01:27:56 ~9 min macos 📦zip
✔️ 54a5313 #6 2024-12-23 23:52:59 ~3 min macos 📦zip
✔️ 54a5313 #6 2024-12-23 23:53:21 ~4 min ios 📦zip
✔️ 54a5313 #6 2024-12-23 23:54:29 ~5 min windows 📦zip
✔️ 54a5313 #6 2024-12-23 23:54:34 ~5 min linux 📦zip
✔️ 54a5313 #6 2024-12-23 23:54:45 ~5 min android 📦aar
✖️ 54a5313 #5 2024-12-23 23:55:15 ~6 min tests 📄log
✔️ 54a5313 #6 2024-12-23 23:55:25 ~6 min tests-rpc 📄log
✔️ 54a5313 #5 2024-12-23 23:59:24 ~10 min macos 📦zip
✖️ 840f7ec #6 2025-01-01 04:45:32 ~3 min tests 📄log
✔️ 840f7ec #7 2025-01-01 04:46:29 ~4 min ios 📦zip
✔️ 840f7ec #7 2025-01-01 04:46:35 ~4 min macos 📦zip
✔️ 840f7ec #7 2025-01-01 04:48:04 ~5 min linux 📦zip
✔️ 840f7ec #7 2025-01-01 04:48:12 ~5 min android 📦aar
✔️ 840f7ec #7 2025-01-01 04:48:29 ~5 min windows 📦zip
✔️ 840f7ec #7 2025-01-01 04:48:48 ~6 min tests-rpc 📄log
✔️ 840f7ec #6 2025-01-01 04:49:04 ~6 min macos 📦zip
✖️ 776cbc5 #7 2025-01-07 01:09:25 ~3 min tests 📄log
✔️ 776cbc5 #8 2025-01-07 01:10:08 ~3 min macos 📦zip
✔️ 776cbc5 #8 2025-01-07 01:10:51 ~4 min ios 📦zip
✔️ 776cbc5 #8 2025-01-07 01:11:27 ~5 min windows 📦zip
✔️ 776cbc5 #8 2025-01-07 01:11:51 ~5 min linux 📦zip
✔️ 776cbc5 #8 2025-01-07 01:11:55 ~5 min android 📦aar
✔️ 776cbc5 #8 2025-01-07 01:12:23 ~6 min tests-rpc 📄log
✔️ 776cbc5 #7 2025-01-07 01:15:28 ~9 min macos 📦zip
✖️ e122d8d #8 2025-01-08 00:23:17 ~2 min tests 📄log
✔️ e122d8d #9 2025-01-08 00:24:36 ~3 min windows 📦zip
✔️ e122d8d #9 2025-01-08 00:24:47 ~3 min macos 📦zip
✔️ e122d8d #9 2025-01-08 00:26:00 ~5 min linux 📦zip
✔️ e122d8d #9 2025-01-08 00:26:13 ~5 min android 📦aar
✔️ e122d8d #9 2025-01-08 00:26:53 ~6 min ios 📦zip
✔️ e122d8d #9 2025-01-08 00:27:00 ~6 min tests-rpc 📄log
✔️ e122d8d #8 2025-01-08 00:29:02 ~8 min macos 📦zip
✖️ 6fc5ae5 #9 2025-01-08 03:04:53 ~1 min tests 📄log
✔️ 6fc5ae5 #10 2025-01-08 03:07:07 ~3 min windows 📦zip
✔️ 6fc5ae5 #10 2025-01-08 03:07:08 ~3 min macos 📦zip
✔️ 6fc5ae5 #10 2025-01-08 03:08:02 ~4 min ios 📦zip
✔️ 6fc5ae5 #10 2025-01-08 03:09:16 ~5 min tests-rpc 📄log
✔️ 6fc5ae5 #10 2025-01-08 03:16:45 ~13 min linux 📦zip
✖️ fed4d13 #10 2025-01-09 21:30:35 ~1 min tests 📄log
✔️ fed4d13 #11 2025-01-09 21:32:51 ~3 min macos 📦zip
✔️ fed4d13 #11 2025-01-09 21:33:14 ~4 min windows 📦zip
✔️ fed4d13 #11 2025-01-09 21:33:35 ~4 min ios 📦zip
✔️ fed4d13 #11 2025-01-09 21:34:31 ~5 min linux 📦zip
✔️ fed4d13 #11 2025-01-09 21:34:42 ~5 min android 📦aar
✔️ fed4d13 #11 2025-01-09 21:35:22 ~6 min tests-rpc 📄log
Commit #️⃣ Finished (UTC) Duration Platform Result
✖️ e19dfeb #11 2025-01-09 22:04:42 ~1 min tests 📄log
✔️ e19dfeb #12 2025-01-09 22:06:56 ~3 min windows 📦zip
✔️ e19dfeb #12 2025-01-09 22:07:36 ~4 min macos 📦zip
✔️ e19dfeb #12 2025-01-09 22:07:40 ~4 min ios 📦zip
✔️ e19dfeb #12 2025-01-09 22:08:04 ~5 min linux 📦zip
✔️ e19dfeb #12 2025-01-09 22:08:43 ~5 min android 📦aar
✖️ e19dfeb #12 2025-01-09 22:09:21 ~6 min tests-rpc 📄log
✔️ e19dfeb #11 2025-01-09 22:13:30 ~10 min macos 📦zip
✖️ 58de9ca #12 2025-01-09 22:32:45 ~1 min tests 📄log
✔️ 58de9ca #13 2025-01-09 22:34:43 ~3 min windows 📦zip
✔️ 58de9ca #13 2025-01-09 22:34:43 ~3 min macos 📦zip
✔️ 58de9ca #13 2025-01-09 22:34:59 ~4 min ios 📦zip
✔️ 58de9ca #12 2025-01-09 22:36:06 ~5 min macos 📦zip
✔️ 58de9ca #13 2025-01-09 22:36:30 ~5 min linux 📦zip
✔️ 58de9ca #13 2025-01-09 22:36:51 ~6 min android 📦aar
✔️ 58de9ca #13 2025-01-09 22:37:02 ~6 min tests-rpc 📄log

@adklempner adklempner force-pushed the feat/local-telem-grafana branch 2 times, most recently from c59e6a4 to af88f60 Compare November 25, 2024 22:07
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 3.70370% with 78 lines in your changes missing coverage. Please review.

Project coverage is 13.60%. Comparing base (ad28f15) to head (af88f60).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
telemetry/prometheus.go 0.00% 54 Missing ⚠️
telemetry/client.go 0.00% 22 Missing ⚠️
wakuv2/waku.go 50.00% 2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (ad28f15) and HEAD (af88f60). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (ad28f15) HEAD (af88f60)
unit 1 0
Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #6122       +/-   ##
============================================
- Coverage    60.89%   13.60%   -47.30%     
============================================
  Files          824      810       -14     
  Lines       109317   107825     -1492     
============================================
- Hits         66569    14669    -51900     
- Misses       34927    91251    +56324     
+ Partials      7821     1905     -5916     
Flag Coverage Δ
functional 13.60% <3.70%> (+<0.01%) ⬆️
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
wakuv2/common/metrics.go 100.00% <100.00%> (ø)
wakuv2/waku.go 45.51% <50.00%> (-23.27%) ⬇️
telemetry/client.go 0.00% <0.00%> (-73.12%) ⬇️
telemetry/prometheus.go 0.00% <0.00%> (ø)

... and 648 files with indirect coverage changes

@adklempner adklempner force-pushed the feat/local-telem-grafana branch from ec960f0 to 54a5313 Compare December 23, 2024 23:48
@adklempner adklempner force-pushed the feat/local-telem-grafana branch from 776cbc5 to e122d8d Compare January 8, 2025 00:20
@adklempner adklempner force-pushed the feat/local-telem-grafana branch 2 times, most recently from fed4d13 to e19dfeb Compare January 9, 2025 22:02
@adklempner adklempner force-pushed the feat/local-telem-grafana branch from e19dfeb to 58de9ca Compare January 9, 2025 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants